From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31517 invoked by alias); 16 Dec 2009 08:48:17 -0000 Received: (qmail 31508 invoked by uid 22791); 16 Dec 2009 08:48:16 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from oden.vtab.com (HELO oden.vtab.com) (62.20.90.195) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Dec 2009 08:48:10 +0000 Received: from oden.vtab.com (oden.vtab.com [127.0.0.1]) by oden.vtab.com (Postfix) with ESMTP id E9BE426EF06; Wed, 16 Dec 2009 09:48:06 +0100 (CET) Received: from polhem (c83-253-27-210.bredband.comhem.se [83.253.27.210]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by oden.vtab.com (Postfix) with ESMTP id BC1B826EEC8; Wed, 16 Dec 2009 09:48:06 +0100 (CET) From: "Jakob Engblom" To: "'Vladimir Prus'" , "'Michael Snyder'" Cc: References: <00d001ca265a$ddd0c800$99725800$@com> <4B27E619.8080607@vmware.com> <200912161106.12861.vladimir@codesourcery.com> In-Reply-To: <200912161106.12861.vladimir@codesourcery.com> Subject: RE: GDB MI Reverse Commands added [3 of 3] Date: Wed, 16 Dec 2009 08:48:00 -0000 Message-ID: <010001ca7e2c$7ce406e0$76ac14a0$@com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00205.txt.bz2 > It does not seem like any of them were addressed. When they are addressed, > this patch is OK. Because the only non-mechanical change is replacement of > FIXME with a suitable comment, and reverse-mode experts are in much better > position to decide if a comment captures the behaviour properly, I don't > think I have to re-review any revision of this patch -- please commit dir= ectly > when you think it's ready. I think they are. The latest file that Michael Snyder attached: * Is called "mi-reverse.exp" * Does use set MIFLAGS "-i=3Dmi"=20 * And the FIXME comment has been replaced with a better comment: # Test exec-reverse-next # It takes two steps to get back to the previous line, # as the first step moves us to the start of the current line, # and the one after that moves back to the previous line. mi_execute_to "exec-next --reverse 2" \ "end-stepping-range" "main" "" \ "basics.c" $line_main_hello "" \ "reverse next to get over the call to do_nothing" So it looks to me like all the comments have been addressed, in the patch i= n the email at http://sourceware.org/ml/gdb-patches/2009-12/msg00199.html .=20 Best regards, /jakob _______________________________________________________ Jakob Engblom, PhD, Technical Marketing Manager Virtutech=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Direct: +46= 8 690 07 47=A0=A0=A0 Drottningholmsv=E4gen 22=A0=A0=A0=A0=A0 Mobile: +46 709 242 646=A0=A0 11243 Stockholm=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Web:=A0=A0=A0 www.virtu= tech.com=A0 Sweden ________________________________________________________ =A0=20