From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26176 invoked by alias); 26 Feb 2003 17:44:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26167 invoked from network); 26 Feb 2003 17:44:17 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by 172.16.49.205 with SMTP; 26 Feb 2003 17:44:17 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id MAA13294; Wed, 26 Feb 2003 12:32:01 -0500 Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id MAA16426; Wed, 26 Feb 2003 12:44:16 -0500 Message-ID: <00e901c2ddbe$b23815e0$0202040a@catdog> From: "Kris Warkentin" To: "Daniel Jacobowitz" Cc: References: <00d101c2ddbd$6d3bfac0$0202040a@catdog> <20030226173758.GA14836@nevyn.them.org> Subject: Re: [Patch] correctly configure wcwidth in readline Date: Wed, 26 Feb 2003 17:44:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-SW-Source: 2003-02/txt/msg00718.txt.bz2 Here's what seems to me to be a more elegant solution. In aclocal.m4, I just define the obj as wcwidth.o and then the Makefile will either have it or not. cheers, Kris $ cvs diff Makefile.in aclocal.m4 Index: Makefile.in =================================================================== RCS file: /cvs/src/src/readline/Makefile.in,v retrieving revision 1.4 diff -r1.4 Makefile.in 88a89,90 > WCWIDTH_OBJ = @WCWIDTH_OBJ@ > 101c103 < $(srcdir)/mbutil.c --- > $(srcdir)/mbutil.c $(srcdir)/support/wcwidth.c 114c116,117 < text.o nls.o misc.o compat.o xmalloc.o $(HISTOBJ) $(TILDEOBJ) --- > text.o nls.o misc.o compat.o xmalloc.o $(HISTOBJ) $(TILDEOBJ) \ > $(WCWIDTH_OBJ) 148a152,155 > > wcwidth.o: $(srcdir)/support/wcwidth.c > $(RM) $@ > $(CC) $(CCFLAGS) -c $(srcdir)/support/wcwidth.c Index: aclocal.m4 =================================================================== RCS file: /cvs/src/src/readline/aclocal.m4,v retrieving revision 1.4 diff -r1.4 aclocal.m4 1656c1656 < AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH)) --- > AC_CHECK_FUNC(wcwidth, AC_DEFINE(HAVE_WCWIDTH), AC_SUBST(WCWIDTH_OBJ,wcwidth.o)) ----- Original Message ----- From: "Daniel Jacobowitz" To: "Kris Warkentin" Cc: Sent: Wednesday, February 26, 2003 12:37 PM Subject: Re: [Patch] correctly configure wcwidth in readline > On Wed, Feb 26, 2003 at 12:35:16PM -0500, Kris Warkentin wrote: > > > Something like this needs to go through the maintainers of > > > bash/readline first. > > > > The problem is that I couldn't get any response from the bash/readline > > maintainers. I mailed the mailing lists and the owner and got no response. > > I also noticed that there is a readline/ChangeLog.gdb file with local > > changes so I figured if I wasn't getting any lovin' from readline, I might > > at least get it merged into the gdb tree. > > Blech. Yeah, in that case I think this sort of patch is acceptable > (that's not a comment on the actual patch - I don't know much about > readline, I leave that to Elena :) > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer >