(Thanks Michael, I'll try to hit standards this time) The attached fixes an unpleasant bug in trace mechanism. Creating a tracepoint declaration string for remote host, and when more then one memrange item was declared in a tracepoint, the debugger would have leave gaps in the string's buffer, causing unexpected results. Josef Ezra ----- Original Message ----- From: "Michael Snyder" To: "Josef Ezra" Cc: ; ; Sent: Monday, October 02, 2000 2:19 PM Subject: Re: bug in tracepoint protocol implementation > Josef Ezra wrote: > > > > hi > > > > file: tracepoint.c > > function: stringify_collection_list > > > > old: > > count += strlen (end); > > end += count ; > > > > new: > > count += strlen (end); > > end = temp_buf + count ; > > > > reasoning: > > When saving more then one memrange parameter, the old code > > leaves 'gaps' in the temp_buf string. > > Josef, > > Your change is correct (thank you). However, would you > please re-submit it after consulting the file "CONTRIBUTING" > in your gdb source directory? Or see: > http://sources.redhat.com/gdb/#contribute > > Briefly, to streamline the process of accepting GDB > contributions, we request the following format: > > * brief description of the problem being addressed > * ChangeLog entry > * Diff of the changes, such as will be acceptable > as input to "patch" (eg. "cvs diff -c3p tracepoint.c") > > Hate to put you thru the exercise of resubmitting such a > simple patch, but it will be good experience if you intend > to make further GDB contributions (as I hope you will). > > Thanks, > Michael Snyder >