From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16548 invoked by alias); 16 Dec 2013 22:50:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16536 invoked by uid 89); 16 Dec 2013 22:50:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 22:50:13 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 407B222021A; Mon, 16 Dec 2013 23:50:11 +0100 (CET) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 2A56322021B; Mon, 16 Dec 2013 23:50:11 +0100 (CET) Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mr8.u-strasbg.fr (Postfix) with ESMTP id 9991422021A; Mon, 16 Dec 2013 23:50:06 +0100 (CET) Received: from ms15.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id rBGMo6xH026026 ; Mon, 16 Dec 2013 23:50:06 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (Authenticated sender: mullerp) by ms15.u-strasbg.fr (Postfix) with ESMTPSA id 498BB1FD8A; Mon, 16 Dec 2013 23:50:00 +0100 (CET) From: "Pierre Muller" To: "'Pedro Alves'" Cc: References: <52ab8d0e.8aa2420a.30ff.ffffd8f1SMTPIN_ADDED_BROKEN@mx.google.com> <52AF3493.9090708@redhat.com> In-Reply-To: <52AF3493.9090708@redhat.com> Subject: RE: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing Date: Mon, 16 Dec 2013 22:50:00 -0000 Message-ID: <00cb01cefab1$29df0480$7d9d0d80$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-12/txt/msg00608.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: lundi 16 d=E9cembre 2013 18:13 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Fix cygwin compilation failure due to nameless > LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing >=20 > On 12/13/2013 10:37 PM, Pierre Muller wrote: > > Following this thread > > https://sourceware.org/ml/gdb-patches/2013-12/msg00073.html > > > > The patch > > https://sourceware.org/ml/gdb-cvs/2013-12/msg00054.html > > > > introduced a failure for cygwin native build. > > The problem is that __USEWIDE is not considered in the patch. > > > > The patch below fixes this compilation error > > and should allow cygwin to work as mingw. >=20 > Looks fine to me. Thanks for the approval, fix committed with Yao's suggestion concerning the ChangeLog entry. Thank you, Yao! =20 > (Though I wonder why not just use GetModuleFileNameExA > explicitly. In fact, it's what gdbserver does). This is just that GetModuleFileNameEx is a function variable which is set to=20 bad_GetModuleFileNameEx if it is not found inside kernel32 DLL. Using GetModuleFileNameExA would still require that check, separately from GetModuleFileNameEx, so the change would have been bigger without any benefit, at least to my understanding... Pierre Muller