From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2441 invoked by alias); 21 Feb 2011 12:52:00 -0000 Received: (qmail 2431 invoked by uid 22791); 21 Feb 2011 12:51:59 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,TW_SF X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 12:51:54 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p1LCpZaR051654 ; Mon, 21 Feb 2011 13:51:35 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms4.u-strasbg.fr [130.79.204.13]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1LCpYxt032578 ; Mon, 21 Feb 2011 13:51:34 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1LCpYw4022653 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 21 Feb 2011 13:51:34 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <001201cbc46c$5b95b100$12c11300$@muller@ics-cnrs.unistra.fr> <000001cbc473$6ef9d120$4ced7360$@muller@ics-cnrs.unistra.fr> <002401cbc574$a8d990e0$fa8cb2a0$@muller@ics-cnrs.unistra.fr> <20110221102151.GG2600@adacore.com> <009301cbd1bd$88ed0550$9ac70ff0$@muller@ics-cnrs.unistra.fr> <20110221115805.GK2600@adacore.com> In-Reply-To: <20110221115805.GK2600@adacore.com> Subject: RE: [RFA] mingw port: Allow use of cvs GDB on Windows 95 Date: Mon, 21 Feb 2011 13:35:00 -0000 Message-ID: <009901cbd1c6$11b05650$351102f0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00541.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: lundi 21 f=E9vrier 2011 12:58 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] mingw port: Allow use of cvs GDB on Windows 95 >=20 > > + /* Stop any pending selects. On Windows 95 OS, CancelIo function > does not > > + exist. In that case, it can be replaced by a call to > CloseHandle, but > > + this is not necessary here as we do close the Windows handle by > > calling > > + close (scb->fd) below. */ >=20 > Thanks for adding the comment. You forgot to add a second space after > the period on the second line...=20 And on the first line too... > And while I'm nitpicking (I really > apologize), we had a discussion about line length and sort of agreed > on a "soft" limit of 70 characters, and a hard limit of 79, or 80. > Can you try a little shorter lines? (ironic, I know). I promise, > I wouldn't be nitpicking if you weren't going to touch it :). I can at least try... see below, but if I remove "CloseHandle," from the second line, it gets a line length of 62, which is too short, so that I presumed that as long as the line length with it is less than 80, it is still OK? Just tell me if this is correct. Pierre PS: I just saw that I also have an unwanted "src/gdb/" in my ChangeLog entry that I will fix at the same time... ChangeLog entry: 2011-02-21 Pierre Muller * ser-mingw.c (ser_windows_close): Reformat comment to better conform to GNU coding standards. Index: ser-mingw.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/ser-mingw.c,v retrieving revision 1.27 diff -u -p -r1.27 ser-mingw.c --- ser-mingw.c 21 Feb 2011 11:47:12 -0000 1.27 +++ ser-mingw.c 21 Feb 2011 12:43:59 -0000 @@ -221,10 +221,10 @@ ser_windows_close (struct serial *scb) { struct ser_windows_state *state; - /* Stop any pending selects. On Windows 95 OS, CancelIo function does not - exist. In that case, it can be replaced by a call to CloseHandle, but - this is not necessary here as we do close the Windows handle by calling - close (scb->fd) below. */ + /* Stop any pending selects. On Windows 95 OS, CancelIo function does + not exist. In that case, it can be replaced by a call to CloseHandle, + but this is not necessary here as we do close the Windows handle + by calling close (scb->fd) below. */ if (CancelIo) CancelIo ((HANDLE) _get_osfhandle (scb->fd)); state =3D scb->state;