From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31861 invoked by alias); 2 Dec 2007 21:53:32 -0000 Received: (qmail 31850 invoked by uid 22791); 2 Dec 2007 21:53:32 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 21:53:25 +0000 Received: from ICSMULLER (unknown [130.79.244.148]) by ics.u-strasbg.fr (Postfix) with ESMTP id 7DBEF18701A for ; Sun, 2 Dec 2007 22:57:46 +0100 (CET) From: "Pierre Muller" To: References: <002801c8329e$d726e090$8574a1b0$@u-strasbg.fr> <20071202024620.GC15745@ednor.casa.cgf.cx> In-Reply-To: <20071202024620.GC15745@ednor.casa.cgf.cx> Subject: RE: [RFA] gdb/win32-nat.c Step the correct thread Date: Sun, 02 Dec 2007 21:53:00 -0000 Message-ID: <008f01c8352d$c312d190$493874b0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00032.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Christopher Faylor > Sent: Sunday, December 02, 2007 3:46 AM > To: gdb-patches@sourceware.org; Pierre Muller > Subject: Re: [RFA] gdb/win32-nat.c Step the correct thread > > On Thu, Nov 29, 2007 at 04:45:17PM +0100, Pierre Muller wrote: > > While trying to understand the SuspendThread > >counting problems, I tried to single step after changing > >thread, and I noticed that the next event always > >brought me back to the main thread. > > > > There is a bug in the current win32-nat.c source > >which places the trace bit always in the > >main thread, while we should step the thread identified by > >inferior_ptid. > > > > This simple patch corrects this. > > > >The testsuite runs with and without this patch > >show no difference. > > > >OK to check in? > > Ok. Thanks, applied. I am preparing a patch that will get the win32 port of gdb to honor the set schechuler-locking on which stipulates that only the stepped thread will be allowed to executed and all other threads are suspended. The only problem is that I need to reintroduce the suspend_count field in thread_info record for that to work. Pierre