From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16199 invoked by alias); 25 May 2009 12:30:00 -0000 Received: (qmail 16190 invoked by uid 22791); 25 May 2009 12:29:59 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 May 2009 12:29:53 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4PCTlHK087288 ; Mon, 25 May 2009 14:29:47 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4PCT83P029595 ; Mon, 25 May 2009 14:29:14 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4PCT1YW075747 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 25 May 2009 14:29:02 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: Subject: [OBV] fix procfs.c compilation failure Date: Mon, 25 May 2009 12:30:00 -0000 Message-ID: <008301c9dd34$65036910$2f0a3b30$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00559.txt.bz2 Pedro, you apparently missed procfs_wait from procfs.c source when you added the options parameter. This patch allows to compile successfully on i386 OpenSolaris again. Checked in as obvious. I have no idea if options value should be handled inside procfs_wait... as I didn't really try to understand why you added that parameter. Could you check if you think that the code should be modified to handle non-zero options arg? Pierre Muller Pascal language support maintainer for GDB ChangeLog entry: 2009-05-25 Pierre Muller * procfs.c (procfs_wait): Add options parameter. Index: procfs.c =================================================================== RCS file: /cvs/src/src/gdb/procfs.c,v retrieving revision 1.108 diff -u -p -r1.108 procfs.c --- procfs.c 18 May 2009 00:58:38 -0000 1.108 +++ procfs.c 25 May 2009 12:23:35 -0000 @@ -128,7 +128,7 @@ static void procfs_mourn_inferior (struc static void procfs_create_inferior (struct target_ops *, char *, char *, char **, int); static ptid_t procfs_wait (struct target_ops *, - ptid_t, struct target_waitstatus *); + ptid_t, struct target_waitstatus *, int); static int procfs_xfer_memory (CORE_ADDR, gdb_byte *, int, int, struct mem_attrib *attrib, struct target_ops *); @@ -3947,7 +3947,7 @@ syscall_is_lwp_create (procinfo *pi, int static ptid_t procfs_wait (struct target_ops *ops, - ptid_t ptid, struct target_waitstatus *status) + ptid_t ptid, struct target_waitstatus *status, int options) { /* First cut: loosely based on original version 2.1 */ procinfo *pi;