From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Tom Tromey'" <tromey@redhat.com>,
"'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFC] Change OK: to ARI: for ARI rule ignore
Date: Fri, 24 Apr 2009 23:26:00 -0000 [thread overview]
Message-ID: <007501c9c533$d0a9c240$71fd46c0$@u-strasbg.fr> (raw)
In-Reply-To: <m3y6trqll8.fsf@fleche.redhat.com>
Thanks to Joel and Tom for their answers.
I checked the source patch in.
The only thing is that the 6.8 branch will
have new warnings because the OK patterns
are not disregarded anymore, but
I don't think that we will ever release a 6.8.1 anyhow!
My initial idea for gdb_ari.sh turned out to be
wrong (I got more regression)
The final diff for gdb_ari.sh looks like this:
$ cvs diff gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.89
diff -r1.89 gdb_ari.sh
149a150,152
> if (ARI_OK == bug) {
> return
> }
208,209c211,225
< # Skip OK lines
< /\/\* OK \*\// || /\/\* OK: / || /\/\* ARI: / { next; }
---
> # Skip ARI lines
>
> BEGIN {
> ARI_OK = ""
> }
>
> /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
> ARI_OK = gensub(/^.*\/\*
ARI:[[:space:]]*(.*[^[:space:]])[[:space:]]*\*\/.*$/, "\\1", 1, $0)
> # print "ARI line found \"" $0 "\""
> # print "ARI_OK \"" ARI_OK "\""
> }
> ! /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
> ARI_OK = ""
> }
>
Is this OK?
Pierre
next prev parent reply other threads:[~2009-04-24 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 22:27 Pierre Muller
2009-04-22 23:44 ` Tom Tromey
2009-04-23 6:51 ` Pierre Muller
2009-04-23 18:19 ` Tom Tromey
2009-04-24 23:26 ` Pierre Muller [this message]
2009-04-28 13:09 ` Daniel Jacobowitz
2009-05-01 8:18 ` Pierre Muller
2009-05-06 16:15 ` Joel Brobecker
2009-05-06 16:26 ` Pierre Muller
2009-04-23 16:42 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007501c9c533$d0a9c240$71fd46c0$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox