From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6804 invoked by alias); 14 Apr 2009 21:49:43 -0000 Received: (qmail 6794 invoked by uid 22791); 14 Apr 2009 21:49:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Apr 2009 21:49:35 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3ELnTVc060880 for ; Tue, 14 Apr 2009 23:49:31 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3ELnSTp026927 for ; Tue, 14 Apr 2009 23:49:28 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3ELnSaD066405 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Tue, 14 Apr 2009 23:49:28 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFA] gdbadmin/ss/gdb_ari.sh update UCASE rule Date: Tue, 14 Apr 2009 21:49:00 -0000 Message-ID: <007201c9bd4a$e64c9d20$b2e5d760$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00283.txt.bz2 The current UCASE rule triggers lost of false warnings as for instance gdb/breakpoint.c:8522: code: UCASE function: Function name is uppercase. gdb/breakpoint.c:8520: /* Create a vector of all tracepoints. */ gdb/breakpoint.c:8521: gdb/breakpoint.c:8522: VEC(breakpoint_p) * gdb/breakpoint.c:8523: all_tracepoints () gdb/breakpoint.c:8524: { I propose a rule that only looks for: a function name starting with a capital letter at the start of the line, followed by a open brace, optionally parameters, a closing brace and nothing else (apart from spaces) This decreases the number of UCASE code warnings from 66 to 15. The test is still not perfect but at least, most VEC.* related problems are gone. Is this OK? Pierre Muller Pascal language support maintainer for GDB Index: gdb_ari.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.85 diff -u -r1.85 gdb_ari.sh --- gdb_ari.sh 14 Apr 2009 21:19:19 -0000 1.85 +++ gdb_ari.sh 14 Apr 2009 21:42:28 -0000 @@ -461,7 +461,7 @@ Function name is uppercase." category["UCASE function"] = ari_code } -/^[A-Z][[:alnum:]_]*[[:space:]]*\(/ { +/^[A-Z][[:alnum:]_]*[[:space:]]*\([^()]*\)[[:space:]]*$/ { if (is_yacc_or_lex == 0) { fail("UCASE function") }