From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10485 invoked by alias); 6 Nov 2012 11:08:32 -0000 Received: (qmail 10407 invoked by uid 22791); 6 Nov 2012 11:08:30 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT,TW_DW X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 11:08:24 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6B8MgQ040654 ; Tue, 6 Nov 2012 12:08:22 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6B8LJk016625 ; Tue, 6 Nov 2012 12:08:22 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6B8LGK014733 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 6 Nov 2012 12:08:21 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: References: <20121106015848.GA5296@sourceware.org> In-Reply-To: <20121106015848.GA5296@sourceware.org> Subject: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 Date: Tue, 06 Nov 2012 11:08:00 -0000 Message-ID: <007101cdbc0f$07a68fa0$16f3aee0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00106.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de GDB Administrator > Envoy=E9=A0: mardi 6 novembre 2012 02:59 > =C0=A0: gdb-patches@sourceware.org > Objet=A0: New ARI warning Tue Nov 6 01:58:48 UTC 2012 >=20 > 281a282,283 > > gdb/dwarf2read.c:8612: regression: xasprintf: Do not use xasprintf(), > instead use xstrprintf > gdb/dwarf2read.c:8612: xasprintf (&virtual_dwo_name, ', > > gdb/dwarf2read.c:8984: regression: xasprintf: Do not use xasprintf(), > instead use xstrprintf > gdb/dwarf2read.c:8984: xasprintf (&dwp_name, ', dwarf2_per_objfile- > >objfile->name); Doug,=20 could you check the patch below which removes the new ARI warnings about use of=20 xasprintf function in the commit http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html Pierre Muller ChangeLog entry: 2012-11-06 Pierre Muller ARI xasprintf rule fixes. * dwarf2read.c (create_dwo_in_dwp): Use xstrprintf function instead of xasprintf. (open_and_init_dwp_file): Ditto. Index: dwarf2read.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.710 diff -u -p -r1.710 dwarf2read.c --- dwarf2read.c 5 Nov 2012 15:50:21 -0000 1.710 +++ dwarf2read.c 6 Nov 2012 11:00:17 -0000 @@ -8609,13 +8609,14 @@ create_dwo_in_dwp (struct dwp_file *dwp_ (fewer struct dwo_file objects to allocated). Remember that for really large apps there can be on the order of 8K CUs and 200K TUs, or more. */ - xasprintf (&virtual_dwo_name, "virtual-dwo/%d-%d-%d-%d", - sections.abbrev.asection ? sections.abbrev.asection->id : 0, - sections.line.asection ? sections.line.asection->id : 0, - sections.loc.asection ? sections.loc.asection->id : 0, - (sections.str_offsets.asection - ? sections.str_offsets.asection->id - : 0)); + virtual_dwo_name =3D + xstrprintf ("virtual-dwo/%d-%d-%d-%d", + sections.abbrev.asection ? sections.abbrev.asection->id : 0, + sections.line.asection ? sections.line.asection->id : 0, + sections.loc.asection ? sections.loc.asection->id : 0, + (sections.str_offsets.asection + ? sections.str_offsets.asection->id + : 0)); make_cleanup (xfree, virtual_dwo_name); /* Can we use an existing virtual DWO file? */ dwo_file_slot =3D lookup_dwo_file_slot (virtual_dwo_name); @@ -8981,7 +8982,7 @@ open_and_init_dwp_file (const char *comp bfd *dbfd; struct cleanup *cleanups; - xasprintf (&dwp_name, "%s.dwp", dwarf2_per_objfile->objfile->name); + dwp_name =3D xstrprintf ("%s.dwp", dwarf2_per_objfile->objfile->name); cleanups =3D make_cleanup (xfree, dwp_name); dbfd =3D open_dwop_file (dwp_name, comp_dir, 1);