From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10128 invoked by alias); 19 Apr 2011 10:41:52 -0000 Received: (qmail 10115 invoked by uid 22791); 19 Apr 2011 10:41:51 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 10:41:37 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p3JAfZp5089372 for ; Tue, 19 Apr 2011 12:41:35 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [130.79.204.12]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3JAfYjl004488 for ; Tue, 19 Apr 2011 12:41:35 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3JAfYBk032333 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 19 Apr 2011 12:41:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c Date: Tue, 19 Apr 2011 10:41:00 -0000 Message-ID: <006e01cbfe7e$5a8dadc0$0fa90940$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00303.txt.bz2 Still trying to reduce the number of files appearing in ARI list. To avoid both operator at end of line and stay below 80-column limit, I had to use another formatting option for the third parameter of regcache_cooked_write_unsigned function call: As the parameter is aa long function call with multiple parameters, I just indented it with 2 spaces relative to regcache_cooked_write_unsigned start. Is this type of indentation OK? Pierre Muller GDB pascal language maintainer 2011-04-19 Pierre Muller * xstormy16-tdep.c (xstormy16_push_dummy_call): Avoid == at end of line as this is against GNU coding standards. Index: xstormy16-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v retrieving revision 1.114 diff -u -p -r1.114 xstormy16-tdep.c --- xstormy16-tdep.c 18 Mar 2011 18:52:32 -0000 1.114 +++ xstormy16-tdep.c 19 Apr 2011 10:35:47 -0000 @@ -264,11 +264,9 @@ xstormy16_push_dummy_call (struct gdbarc val = value_contents (args[i]); for (j = 0; j < typelen; j += xstormy16_reg_size) regcache_cooked_write_unsigned (regcache, argreg++, - extract_unsigned_integer (val + j, - typelen - j == - 1 ? 1 : - xstormy16_reg_size, - byte_order)); + extract_unsigned_integer (val + j, + typelen - j == 1 ? 1 : xstormy16_reg_size, + byte_order)); } /* Align SP */