From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31962 invoked by alias); 25 May 2009 08:40:15 -0000 Received: (qmail 31945 invoked by uid 22791); 25 May 2009 08:40:13 -0000 X-SWARE-Spam-Status: No, hits=0.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,HK_OBFDOMREQ,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 May 2009 08:40:07 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4P8dgmc022557 ; Mon, 25 May 2009 10:39:42 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4P8dgci068215 ; Mon, 25 May 2009 10:39:42 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4P8df32071337 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 25 May 2009 10:39:42 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <20090522153042.GB23016@adacore.com> <20090522171005.GC15288@ednor.casa.cgf.cx> <004301c9dc6c$29d6a000$7d83e000$@u-strasbg.fr> <20090525061728.GD23016@adacore.com> In-Reply-To: <20090525061728.GD23016@adacore.com> Subject: RE: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro Date: Mon, 25 May 2009 08:40:00 -0000 Message-ID: <006e01c9dd14$5a9cf510$0fd6df30$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00558.txt.bz2 Sorry, I forgot to put the final patch in the email. Concerning the build failure, I managed to get it to work with a 'make distclean' at gdb level, followed by a 'make all-gdb' at src level. ('make all' after distclean fails at gdb level). Pierre Muller Pascal language support maintainer for GDB ChangeLog Entry: 2009-05-24 Pierre Muller * symfile.c (add_shared_symbol_files_command): Remove prototype and function. (_initialize _symfile): Move "add-shared-symbol-files" command and "assf" alias. * windows-nat.c (_initialize_windows_nat): to here. Change "add-shared-symbol-files" to alias. * config/i386/cygwin.mh: Remove NAT_FILE. * config/i386/mingw.mh: Remove NAT_FILE. * config/i386/mingw64.mh: Remove NAT_FILE. * config/i386/nm-cygwin.h: Remove file. * config/i386/nm-cygwin64.h: Remove file. Index: config/i386/nm-cygwin.h =================================================================== RCS file: config/i386/nm-cygwin.h diff -N config/i386/nm-cygwin.h --- config/i386/nm-cygwin.h 14 May 2009 09:37:00 -0000 1.11 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,20 +0,0 @@ -/* Native definitions for Intel x86 running CYGWIN. - Copyright 2002, 2006, 2007, 2008, 2009 Free Software Foundation, Inc. - - This file is part of GDB. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see . */ - -#define ADD_SHARED_SYMBOL_FILES dll_symbol_command -void dll_symbol_command (char *, int); Index: config/i386/nm-cygwin64.h =================================================================== RCS file: config/i386/nm-cygwin64.h diff -N config/i386/nm-cygwin64.h --- config/i386/nm-cygwin64.h 14 May 2009 09:37:00 -0000 1.4 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,19 +0,0 @@ -/* Copyright 2008, 2009 Free Software Foundation, Inc. - - This file is part of GDB. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see . */ - -#define ADD_SHARED_SYMBOL_FILES dll_symbol_command -void dll_symbol_command (char *, int); Index: config/i386/mingw64.mh =================================================================== RCS file: /cvs/src/src/gdb/config/i386/mingw64.mh,v retrieving revision 1.2 retrieving revision 1.3 diff -u -p -r1.2 -r1.3 --- config/i386/mingw64.mh 12 Jan 2009 01:10:28 -0000 1.2 +++ config/i386/mingw64.mh 24 May 2009 12:27:35 -0000 1.3 @@ -1,2 +1 @@ NATDEPFILES= i386-nat.o windows-nat.o amd64-windows-nat.o -NAT_FILE=nm-cygwin64.h Index: config/i386/mingw.mh =================================================================== RCS file: /cvs/src/src/gdb/config/i386/mingw.mh,v retrieving revision 1.3 retrieving revision 1.4 diff -u -p -r1.3 -r1.4 --- config/i386/mingw.mh 12 Jan 2009 01:10:28 -0000 1.3 +++ config/i386/mingw.mh 24 May 2009 12:27:35 -0000 1.4 @@ -1,4 +1,3 @@ MH_CFLAGS= NATDEPFILES= i386-nat.o windows-nat.o i386-windows-nat.o -NAT_FILE=nm-cygwin.h XM_CLIBS= Index: config/i386/cygwin.mh =================================================================== RCS file: /cvs/src/src/gdb/config/i386/cygwin.mh,v retrieving revision 1.10 retrieving revision 1.11 diff -u -p -r1.10 -r1.11 --- config/i386/cygwin.mh 12 Jan 2009 01:10:28 -0000 1.10 +++ config/i386/cygwin.mh 24 May 2009 12:27:35 -0000 1.11 @@ -1,4 +1,3 @@ MH_CFLAGS= NATDEPFILES= i386-nat.o windows-nat.o i386-windows-nat.o -NAT_FILE=nm-cygwin.h XM_CLIBS= Index: windows-nat.c =================================================================== RCS file: /cvs/src/src/gdb/windows-nat.c,v retrieving revision 1.191 retrieving revision 1.192 diff -u -p -r1.191 -r1.192 --- windows-nat.c 21 May 2009 15:48:41 -0000 1.191 +++ windows-nat.c 24 May 2009 12:27:35 -0000 1.192 @@ -2205,6 +2205,10 @@ _initialize_windows_nat (void) add_com_alias ("sharedlibrary", "dll-symbols", class_alias, 1); + add_com_alias ("add-shared-symbol-files", "dll-symbols", class_alias, 1); + + add_com_alias ("assf", "dll-symbols", class_alias, 1); + #ifdef __CYGWIN__ add_setshow_boolean_cmd ("shell", class_support, &useshell, _("\ Set use of shell to start subprocess."), _("\ Index: symfile.c =================================================================== RCS file: /cvs/src/src/gdb/symfile.c,v retrieving revision 1.228 retrieving revision 1.229 diff -u -p -r1.228 -r1.229 --- symfile.c 22 May 2009 23:49:13 -0000 1.228 +++ symfile.c 24 May 2009 12:27:35 -0000 1.229 @@ -96,8 +96,6 @@ static void symbol_file_add_main_1 (char static void add_symbol_file_command (char *, int); -static void add_shared_symbol_files_command (char *, int); - static void reread_separate_symbols (struct objfile *objfile); static void cashier_psymtab (struct partial_symtab *); @@ -2234,16 +2232,7 @@ add_symbol_file_command (char *args, int do_cleanups (my_cleanups); } ♀ -static void -add_shared_symbol_files_command (char *args, int from_tty) -{ -#ifdef ADD_SHARED_SYMBOL_FILES - ADD_SHARED_SYMBOL_FILES (args, from_tty); -#else - error (_("This command is not available in this configuration of GDB.")); -#endif -} -♀ + /* Re-read symbols if a symbol-file has changed. */ void reread_symbols (void) @@ -4102,13 +4091,6 @@ with the text. SECT is a section name t &cmdlist); set_cmd_completer (c, filename_completer); - c = add_cmd ("add-shared-symbol-files", class_files, - add_shared_symbol_files_command, _("\ -Load the symbols from shared objects in the dynamic linker's link map."), - &cmdlist); - c = add_alias_cmd ("assf", "add-shared-symbol-files", class_files, 1, - &cmdlist); - c = add_cmd ("load", class_files, load_command, _("\ Dynamically load FILE into the running program, and record its symbols\n\ for access from GDB.\n\