From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9265 invoked by alias); 8 Jun 2009 16:06:00 -0000 Received: (qmail 9254 invoked by uid 22791); 8 Jun 2009 16:05:59 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Jun 2009 16:05:49 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n58G5UJn097647 ; Mon, 8 Jun 2009 18:05:30 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n58G5UCK070767 ; Mon, 8 Jun 2009 18:05:30 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n58G5T5E008707 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 8 Jun 2009 18:05:29 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: References: <006001c9e6be$6fad8fb0$4f08af10$@u-strasbg.fr> In-Reply-To: Subject: RE: [RFA] Fix bug in add_alias_cmd Date: Mon, 08 Jun 2009 16:06:00 -0000 Message-ID: <006901c9e852$f216c2b0$d6444810$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00182.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Monday, June 08, 2009 5:37 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Fix bug in add_alias_cmd >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> This is due to "bu" being an alias command of "ubreak" > Pierre> for xdb options, but "ubreak" doesn't seem to exist anywhere > Pierre> and I found no trace of it anywhere is the sources :( >=20 > Pierre> I fact after looking at the sources, it appears to me > Pierre> that the assertion itself is wrong. > Pierre> prehookee should also be NULL, as the other pointers tested. >=20 > Pierre> This small patch fixes it. >=20 > Pierre> OK to commit? >=20 > Yes, thanks. > IMO, you could have put this patch in under the "obvious" rule. Thanks, I committed the patch. =20 > Pierre> PS: What should we do about > Pierre> Could I also remove that line > Pierre> if (xdb_commands) > Pierre> { > Pierre> add_com_alias ("ba", "break", class_breakpoint, 1); > Pierre> add_com_alias ("bu", "ubreak", class_breakpoint, 1); > Pierre> } >=20 > You can just delete the "bu" line. Patch also committed. =20 > If you want you could do some archaeology to see whether ubreak ever > existed and, if so, when and why it was removed. I already did a=20 grep -R -n -i ubreak *=20 at src/gdb level, it returned only that single line, where else could I find something? Google on 'gdb ubreak' didn't find anything interesting either. Pierre