From: "Michael Snyder" <msnyder@sonic.net>
To: "Daniel Jacobowitz" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] symfile.c, find_separate_debug_file
Date: Fri, 03 Aug 2007 04:41:00 -0000 [thread overview]
Message-ID: <006901c7d587$db360400$677ba8c0@sonic.net> (raw)
In-Reply-To: <20070803013005.GA22901@caradoc.them.org>
> On Thu, Aug 02, 2007 at 06:14:44PM -0700, Michael Snyder wrote:
> > Just for a change, here's one that was not inspired by Coverity.
> >
> > Find separate debug file does not work in the case where the path
> > lies in the global debug file directory -- because we stick an extra
> > slash into the pathname.
>
> Why doesn't it work with an extra slash? It shouldn't make a
> difference. Anyway:
>
> > * symfile.c (find_separate_debug_file): While consing up a path,
> > don't stick in an extra DIR_SEPARATOR.
>
> That's right, use DIR_SEPARATOR :-) IS_DIR_SEPARATOR in this case, I
> think?
The existing code doesn't use it. If you want me to undertake to
revise the code to use DIR_SEPARATOR, I'll be glad to do it.
But it shouldn't hold up this patch.
next prev parent reply other threads:[~2007-08-03 4:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 1:14 msnyder
2007-08-03 1:30 ` Daniel Jacobowitz
2007-08-03 4:41 ` Michael Snyder [this message]
2007-08-03 11:40 ` Daniel Jacobowitz
2007-08-03 14:47 ` Michael Snyder
2007-08-03 15:00 ` Daniel Jacobowitz
2007-08-03 15:09 ` Michael Snyder
2007-08-03 15:19 ` Daniel Jacobowitz
2007-08-03 15:49 ` Andreas Schwab
2007-08-03 12:31 ` Eli Zaretskii
2007-08-03 14:43 ` Michael Snyder
2007-08-03 14:51 ` Daniel Jacobowitz
2007-08-03 17:12 ` Eli Zaretskii
2007-08-03 17:26 ` Michael Snyder
2007-08-03 5:54 ` Mark Kettenis
2007-08-03 7:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006901c7d587$db360400$677ba8c0@sonic.net' \
--to=msnyder@sonic.net \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox