From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9221 invoked by alias); 8 Apr 2011 00:01:29 -0000 Received: (qmail 9211 invoked by uid 22791); 8 Apr 2011 00:01:27 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,RCVD_IN_PSBL X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Apr 2011 00:01:21 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p3801F7A049124 ; Fri, 8 Apr 2011 02:01:15 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [130.79.204.10]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3801Fwq063118 ; Fri, 8 Apr 2011 02:01:15 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p3801DBB051632 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 8 Apr 2011 02:01:14 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" , References: <005101cbf4ae$1dca5fc0$595f1f40$@muller@ics-cnrs.unistra.fr> <201104080044.27841.pedro@codesourcery.com> In-Reply-To: <201104080044.27841.pedro@codesourcery.com> Subject: RE: [RFA 2/2] Remove old Cygwin1.5 support Date: Fri, 08 Apr 2011 00:01:00 -0000 Message-ID: <006801cbf580$1581fad0$4085f070$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00120.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: vendredi 8 avril 2011 01:44 > =C0=A0: gdb-patches@sourceware.org > Cc=A0: Pierre Muller > Objet=A0: Re: [RFA 2/2] Remove old Cygwin1.5 support >=20 > On Wednesday 06 April 2011 23:58:17, Pierre Muller wrote: > > if (path_ptr) > > { > > + int len =3D cygwin_conv_path_list (CCP_POSIX_TO_WIN_A, path_ptr, > NULL, > > 0); >=20 > Your use of `len' for the variable's name confused me into > thinking there's an off-by-one below. The cygwin_conv_path_list function > returns a byte size including the null terminator, not a string > length. Please rename the variable to `size'. Okay with that change. Checked in with your variable name modification. Thanks for the approval, Pierre