From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WcsvFqum3mlJehcAWB0awg (envelope-from ) for ; Tue, 14 Apr 2026 16:42:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1MY86Zzg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Cb5NdC7n; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1MY86Zzg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Cb5NdC7n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 54EC81E04F; Tue, 14 Apr 2026 16:42:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B411F1E04F for ; Tue, 14 Apr 2026 16:42:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 326DF4BA23DD for ; Tue, 14 Apr 2026 20:42:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 326DF4BA23DD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1MY86Zzg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Cb5NdC7n; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1MY86Zzg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Cb5NdC7n Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 837674BA2E08 for ; Tue, 14 Apr 2026 20:41:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 837674BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 837674BA2E08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776199310; cv=none; b=bGbDjAvMLm+BO2vwOd8XvXud34NNSw0lermOaLkHNy0XRlEb89MSonfDJ8uDJT9YjR9nFoIw2zleZ4EAySfkQxucDSZnME2KK5l3o3ahWpNJy1L2FZx6+EuGdnAC2yPnOpEPZn7DilquDk/aKcV6AyVoPKn976pSRXP2WkMFubw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776199310; c=relaxed/simple; bh=YslTASabImuqpbPb2zoghhYNWlN35HzUfj1U2oxBKLg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=nYZ4DGcNiGmTMvR7weNv1lMVA4w6SJ71Bz9aaG+8v3WZzXjI60KCpUwTEwp7yoQPlM+Odg0dtPnWlIGc8wIx8TeScFpmjMmWFX9KWxVEYZRBBYenlv0EmTEdu0KZ59iZOmUrhMtV+3t1Y7x2Yn2UTrrcm3kg4o8VOk8Xnc27a38= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 837674BA2E08 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA70C6A94C; Tue, 14 Apr 2026 20:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776199308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPkvGuRW29HdOtWYrrZ8UuEbQGiJ4HpDIpSJ9k1GBEc=; b=1MY86ZzgyofKRIj/nojq4GqLSblbeT4uW4GOKfFFpBY1J83JBGkXpBgj4fXXZAlGBzsd/h RbqiOVB2GVyAh71XmcfRvqADamT8joLwQxxtLBpzAzief6yZRLI4epC3FpKpTgCsWjzGgt 4goseZF7xWajPwdV17a8XTHw9dnWMEY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776199308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPkvGuRW29HdOtWYrrZ8UuEbQGiJ4HpDIpSJ9k1GBEc=; b=Cb5NdC7niPYzQuuh9fZh34Hc1HsLObjm7wfmHewvLz/HMrSu/NnghacL7pVoa+XptQAvlO 71kILVd5be/Uw3Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1MY86Zzg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Cb5NdC7n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776199308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPkvGuRW29HdOtWYrrZ8UuEbQGiJ4HpDIpSJ9k1GBEc=; b=1MY86ZzgyofKRIj/nojq4GqLSblbeT4uW4GOKfFFpBY1J83JBGkXpBgj4fXXZAlGBzsd/h RbqiOVB2GVyAh71XmcfRvqADamT8joLwQxxtLBpzAzief6yZRLI4epC3FpKpTgCsWjzGgt 4goseZF7xWajPwdV17a8XTHw9dnWMEY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776199308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPkvGuRW29HdOtWYrrZ8UuEbQGiJ4HpDIpSJ9k1GBEc=; b=Cb5NdC7niPYzQuuh9fZh34Hc1HsLObjm7wfmHewvLz/HMrSu/NnghacL7pVoa+XptQAvlO 71kILVd5be/Uw3Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A48E04B630; Tue, 14 Apr 2026 20:41:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zLXvJoym3mmKaQAAD6G6ig (envelope-from ); Tue, 14 Apr 2026 20:41:48 +0000 Message-ID: <0067e228-c1f2-4cdc-9361-60a5c7b2fc82@suse.de> Date: Tue, 14 Apr 2026 22:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] [gdb] Fix missing print frame when stepping out of function To: Andrew Burgess , gdb-patches@sourceware.org References: <20260410101252.1805303-1-tdevries@suse.de> <878qapfqoz.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <878qapfqoz.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: BA70C6A94C X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/14/26 6:32 PM, Andrew Burgess wrote: > Tom de Vries writes: > >> This patch series consisting of four patches. >> >> The first patch extends test-case gdb.opt/inline-cmds.exp. >> >> The second patch does some refactoring, to make the following fix minimal. >> >> The third patch contains a fix for PR33981. >> >> The fourth patch does a cleanup in function print_stop_location. >> >> A v1 was submitted here [1]. >> >> Changes in v2 [2]: >> - added two refactoring patches >> - changed approach after review comment by Andrew, changing >> in_step_start_function usage to notice stepping in and out of inlined >> functions >> >> Changes in v3 [3]: >> - dropped first refactoring patch >> - merged second refactoring patch into patch containing fix >> - changed approach from using find_symbol_for_pc_sect_maybe_inline to using >> get_frame_function >> - extended test-case gdb.opt/inline-cmds.exp >> - added patch with cleanup in function print_stop_location >> >> Changes in v4: >> - factored out patch extending test-case gdb.opt/inline-cmds.exp >> - re-instated refactoring patch >> - updated cleanup patch to use selected frame instead of current frame > > Thanks for all your work on this series. > > I don't fully see the need for the split between patches #2 and #3, but > I don't object if that's your preference. I think this is looking good. > Thanks Andrew, pushed. - Tom > Approved-By: Andrew Burgess > > Thanks, > Andrew > > > >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33981 >> >> [1] v1 https://sourceware.org/pipermail/gdb-patches/2026-March/225916.html >> [2] v2 (RFC) https://sourceware.org/pipermail/gdb-patches/2026-March/226269.html >> [3] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226330.html >> >> Andrew Burgess (2): >> [gdb/testsuite] Extend gdb.opt/inline-cmds.exp >> gdb: use get_current_frame consistently in print_stop_location >> >> Tom de Vries (2): >> [gdb] Add thread_control_state::step_start_function methods >> gdb: fix missing print frame when stepping out of function >> >> gdb/gdbthread.h | 36 ++++++++++++++- >> gdb/infcmd.c | 3 +- >> gdb/infrun.c | 25 ++++++----- >> .../gdb.dwarf2/dw2-extend-inline-block.exp | 45 +++++++++++++++++-- >> gdb/testsuite/gdb.opt/inline-cmds.exp | 33 +++++++++----- >> 5 files changed, 113 insertions(+), 29 deletions(-) >> >> >> base-commit: d7e49fd331d5a9a66d467c7d5cb4b5fc156a1ee0 >> -- >> 2.51.0 >