Re: [PATCH v3 10/13] don't check for unistd.h

Tom Tromey
2013-11-20T15:50:25Z

Tom> I'm probably going to revert the whole series tomorrow morning.

Tom> I'll send a bug report to gnulib.

Ok, I dug some more, and I discovered that the gnulib "strerror" module
is the root of our trouble. Dropping it fixes the problem.

Therefore I'm checking in the appended patch. (I omitted all the
auto-generated crud from it for clarity.)

I send a second note to bug-gnulib with my findings.

I am somewhat more skeptical of gnulib after this experience.

Tom

From 079a28f2235d6c294f643351d2bee248e311b025 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Wed, 20 Nov 2013 08:19:05 -0700
Subject: [PATCH] remove strerror module

This fixes the mingw build breakage reported by Pierre.

I found that the gnulib strerror module somehow requires us to pull in
the gethostname module. However, pulling in the gethostname module
makes many things break.

I've sent a bug report to gnulib.

Meanwhile, removing the strerror module should not harm gdb and fixes
the build.

I'm checking this in.

2013-11-20 Tom Tromey <tromey@redhat.com>

* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
strerror module.
* gnulib/aclocal.m4: Update.
* gnulib/config.in: Update.
* gnulib/configure: Update.
* gnulib/import/Makefile.am: Update.
* gnulib/import/Makefile.in: Update.
* gnulib/import/errno.in.h: Remove.
* gnulib/import/intprops.h: Remove.
* gnulib/import/m4/errno_h.m4: Remove.
* gnulib/import/m4/gnulib-cache.m4: Update.
* gnulib/import/m4/gnulib-comp.m4: Update.
* gnulib/import/m4/strerror.m4: Remove.
* gnulib/import/m4/sys_socket_h.m4: Remove.
* gnulib/import/strerror-override.c: Remove.
* gnulib/import/strerror-override.h: Remove.
* gnulib/import/strerror.c: Remove.
* gnulib/update-gnulib.sh: Update.
---
gdb/ChangeLog | 21 ++
gdb/gnulib/aclocal.m4 | 3 -
gdb/gnulib/config.in | 16 -
gdb/gnulib/configure | 665 ++--------------------------------
gdb/gnulib/import/Makefile.am | 61 +---
gdb/gnulib/import/Makefile.in | 84 ++---
gdb/gnulib/import/errno.in.h | 279 --------------
gdb/gnulib/import/intprops.h | 319 ----------------
gdb/gnulib/import/m4/errno_h.m4 | 137 -------
gdb/gnulib/import/m4/gnulib-cache.m4 | 3 +-
gdb/gnulib/import/m4/gnulib-comp.m4 | 25 --
gdb/gnulib/import/m4/strerror.m4 | 96 -----
gdb/gnulib/import/m4/sys_socket_h.m4 | 176 ---------
gdb/gnulib/import/strerror-override.c | 302 ---------------
gdb/gnulib/import/strerror-override.h | 56 ---
gdb/gnulib/import/strerror.c | 70 ----
gdb/gnulib/update-gnulib.sh | 1 -
17 files changed, 84 insertions(+), 2230 deletions(-)
delete mode 100644 gdb/gnulib/import/errno.in.h
delete mode 100644 gdb/gnulib/import/intprops.h
delete mode 100644 gdb/gnulib/import/m4/errno_h.m4
delete mode 100644 gdb/gnulib/import/m4/strerror.m4
delete mode 100644 gdb/gnulib/import/m4/sys_socket_h.m4
delete mode 100644 gdb/gnulib/import/strerror-override.c
delete mode 100644 gdb/gnulib/import/strerror-override.h
delete mode 100644 gdb/gnulib/import/strerror.c

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3afa68e..4488a9f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,24 @@
+2013-11-20 Tom Tromey <tromey@redhat.com>
+
+ * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
+ strerror module.
+ * gnulib/aclocal.m4: Update.
+ * gnulib/config.in: Update.
+ * gnulib/configure: Update.
+ * gnulib/import/Makefile.am: Update.
+ * gnulib/import/Makefile.in: Update.
+ * gnulib/import/errno.in.h: Remove.
+ * gnulib/import/intprops.h: Remove.
+ * gnulib/import/m4/errno_h.m4: Remove.
+ * gnulib/import/m4/gnulib-cache.m4: Update.
+ * gnulib/import/m4/gnulib-comp.m4: Update.
+ * gnulib/import/m4/strerror.m4: Remove.
+ * gnulib/import/m4/sys_socket_h.m4: Remove.
+ * gnulib/import/strerror-override.c: Remove.
+ * gnulib/import/strerror-override.h: Remove.
+ * gnulib/import/strerror.c: Remove.
+ * gnulib/update-gnulib.sh: Update.
+
2013-11-19 Yao Qi <yao@codesourcery.com>

* lib/mi-support.exp (mi_child_regexp): Remove 'whatever'.
diff --git a/gdb/gnulib/update-gnulib.sh b/gdb/gnulib/update-gnulib.sh
index 5bbe65e..21f0b59 100644
--- a/gdb/gnulib/update-gnulib.sh
+++ b/gdb/gnulib/update-gnulib.sh
@@ -37,7 +37,6 @@ IMPORTED_GNULIB_MODULES="\
update-copyright \
unistd \
pathmax \
- strerror \
strstr \
dirent \
sys_stat \
--
1.8.1.4