[PATCH] Avoid seg fault in sim/cris/sim-if.c

["Roger Sayle" <roger@nextmovesoftware.com>]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]


Typing "target sim" in GDB built with --target=cris-elf, crashes immediately
after being launched with "gdb ./a.out".  The issue is that STATE_PROG_ARGV
may return NULL, and this isn't tested before dereferencing the pointer.

If approved, please could someone commit this for me.
Thanks in advance.

2026-08-01  Roger Sayle  <roger@nextmovesoftware.com>

ChangeLog
	* sim/cris/sim-if.c (sim_open): Check that prog_argv isn't NULL.



[-- Attachment #2: patchgd.txt --]
[-- Type: text/plain, Size: 597 bytes --]

diff --git a/sim/cris/sim-if.c b/sim/cris/sim-if.c
index 12c80983208..3babbb058b7 100644
--- a/sim/cris/sim-if.c
+++ b/sim/cris/sim-if.c
@@ -770,8 +770,9 @@ sim_open (SIM_OPEN_KIND kind, host_callback *callback, struct bfd *abfd,
       for (envc = 0; environ[envc] != NULL; envc++)
 	len += strlen (environ[envc]) + 1;
 
-      for (i = 0; prog_argv[i] != NULL; my_argc++, i++)
-	len += strlen (prog_argv[i]) + 1;
+      if (prog_argv != NULL)
+	for (i = 0; prog_argv[i] != NULL; my_argc++, i++)
+	  len += strlen (prog_argv[i]) + 1;
 
       envstart = (envtop - len) & ~8191;