From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8701 invoked by alias); 23 Oct 2009 08:52:50 -0000 Received: (qmail 8686 invoked by uid 22791); 23 Oct 2009 08:52:49 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Oct 2009 08:52:44 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n9N8qQMM005650 ; Fri, 23 Oct 2009 10:52:26 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n9N8qQog091864 ; Fri, 23 Oct 2009 10:52:26 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n9N8qPWm057241 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 23 Oct 2009 10:52:25 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Paul Pluzhnikov'" , "'Michael Snyder'" Cc: "'Hui Zhu'" , "'Eli Zaretskii'" , References: <4AD91D72.1030802@vmware.com> <4ADE1612.9040708@vmware.com> <4ADE167F.2020309@vmware.com> <4AE0B40B.5020802@vmware.com> <8ac60eac0910221340y2ad104fo5e4229f017957a5b@mail.gmail.com> <4AE0C669.5020001@vmware.com> <8ac60eac0910221425q63b78a7cnb92b0ddf1c8f5e61@mail.gmail.com> <8ac60eac0910221745t3ef6eb56ra6609086ad07f23@mail.gmail.com> <8ac60eac0910221803p2b45453bu17473aa7e9453a60@mail.gmail.com> In-Reply-To: <8ac60eac0910221803p2b45453bu17473aa7e9453a60@mail.gmail.com> Subject: RE: [RFA, 3 of 3] save/restore process record, part 3 (save/restore) Date: Fri, 23 Oct 2009 08:52:00 -0000 Message-ID: <006001ca53be$25d1ab70$71750250$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00561.txt.bz2 I still have problems to compile on Cygwin: gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config - DLOCALEDIR=3D"\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../incl ude/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../. ./src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../ src/gdb/gnulib -Ignulib -DMI_OUT=3D1 -DTUI=3D1 -Wall -Wdeclaration-after-statemen t -Wpointer-arith -Wformat-nonliteral -Wno-unused -Wunused-value -Wno-switch -Wn o-char-subscripts -Werror -c -o record.o -MT record.o -MMD -MP -MF .deps/record. Tpo ../../src/gdb/record.c ../../src/gdb/record.c: In function `record_restore': ../../src/gdb/record.c:2021: warning: unsigned int format, uint32_t arg (arg 2) ../../src/gdb/record.c: In function `cmd_record_save': ../../src/gdb/record.c:2288: warning: unsigned int format, uint32_t arg (arg 2) make[1]: *** [record.o] Error 1 Furthermore, there is a '%ll' rule in ARI that states that: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value Shouldn't this also concern '%lu'? Do we really need long for sizeof function returns? Are there any types (use in record.c) for which=20 sizeof would not fit into a regular "unsigned int" ? Pierre Muller as ARI "maintainer"... > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Paul Pluzhnikov > Envoy=E9=A0: Friday, October 23, 2009 3:03 AM > =C0=A0: Michael Snyder > Cc=A0: Hui Zhu; Eli Zaretskii; gdb-patches@sourceware.org > Objet=A0: Re: [RFA, 3 of 3] save/restore process record, part 3 > (save/restore) >=20 > On Thu, Oct 22, 2009 at 5:45 PM, Paul Pluzhnikov > wrote: >=20 > > More problems: on Linux/x86_64: > > >=20 > > ../../src/gdb/record.c:2062: warning: format '%d' expects type 'int', > > but argument 3 has type 'long unsigned int' >=20 > I've committed attached patch as obvious. >=20 > Thanks, > -- > Paul Pluzhnikov >=20 > 2009-10-22 Paul Pluzhnikov >=20 > * record.c (record_restore, cmd_record_save): Fix warnings.