From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17378 invoked by alias); 4 May 2010 23:25:56 -0000 Received: (qmail 17370 invoked by uid 22791); 4 May 2010 23:25:54 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,TW_BJ,TW_CP,TW_EG X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 23:25:45 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44NPeFY086633 for ; Wed, 5 May 2010 01:25:41 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o44NPeXP051029 for ; Wed, 5 May 2010 01:25:40 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44NPdEv046604 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Wed, 5 May 2010 01:25:40 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [ARI] Remove all editCase warnings Date: Tue, 04 May 2010 23:25:00 -0000 Message-ID: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00081.txt.bz2 This patch handles the 18 occurrences of the editCase function rule. I lowercased most functions, with two exceptions: - in sol-thread.c, ps_lgetLDT is said to be required by solaris libthread_db. - in windows-nat.c, for a bunch of dummy replacements of DLL functions that only exist in some versions. In those two cases, I added a /* ARI: editCase function */ to tell ARI not to mention this. Is this patch reviewable as is, or should I resubmit each file individually? Pierre Muller Pascal language support maintainer for GDB as ARI maintainer. 2010-05-05 Pierre Muller ARI: Fix editCase. * ada-lang.c (ada_remove_Xbn_suffix): Rename to... (ada_remove_xbn_suffix): ...this. (find_old_style_renaming_symbol): Adapt to name change above. * addrmap.c (splay_compare_CORE_ADDR_ptr): Rename to... (splay_compare_core_addr_ptr): ...this. (addrmap_create_mutable): Adapt to name change above. * hppa-tdep.c (hppa_extract_5R_store): Rename to... (hppa_extract_r_store): ...this. (inst_saves_gr): Adapt to name change above. (inst_saves_fr): Adapt to name change above. * hppa-tdep.h (hppa_extract_5R_store): Rename to... (hppa_extract_r_store): ...this. * ia64-tdep.c (slotN_contents): Rename to... (slotn_contents): ...this. (replace_slotN_contents): Rename to... (replace_slotn_contents): ...this. (fetch_instruction): Adapt to name changes above. (ia64_memory_insert_breakpoint): Likewise. (ia64_memory_remove_breakpoint): Likewise. (ia64_breakpoint_from_pc): Likewise. * procfs.c (proc_get_LDT_entry): Rename to... (proc_get_ldt_entry): ...this. (procfs_find_LDT_entry): Rename to... (procfs_find_ldt_entry): ...this. * remote.c (set_remote_protocol_Z_packet_cmd): Rename to... (set_remote_protocol_z_packet_cmd): ...this. (show_remote_protocol_Z_packet_cmd): Rename to... (show_remote_protocol_z_packet_cmd): ...this. (store_register_using_P): Rename to... (store_register_using_p): ...this. (store_register_using_G): Rename to... (store_register_using_g): ...this. (remote_store_registers): Adapt to name changes above. (watchpoint_to_Z_packet): Rename to... (watchpoint_to_z_packet): ...this. (remote_insert_watchpoint): Adapt to name chage above. (remote_remove_watchpoint): Likewise. (_initialize_remote): Adapt to name changes above. * sol-thread.c (ps_lgetLDT): Add ARI comment for editCase. Adapt to name change in procfs.c source. * windows-nat.c (_initialize_check_for_gdb_ini): Add ARI comment to all windows API replacement functions. Index: src/gdb/ada-lang.c =================================================================== RCS file: /cvs/src/src/gdb/ada-lang.c,v retrieving revision 1.258 diff -u -p -r1.258 ada-lang.c --- src/gdb/ada-lang.c 2 May 2010 21:14:59 -0000 1.258 +++ src/gdb/ada-lang.c 4 May 2010 22:14:55 -0000 @@ -855,7 +855,7 @@ ada_remove_po_subprogram_suffix (const c /* Remove trailing X[bn]* suffixes (indicating names in package bodies). */ static void -ada_remove_Xbn_suffix (const char *encoded, int *len) +ada_remove_xbn_suffix (const char *encoded, int *len) { int i = *len - 1; @@ -6471,7 +6471,7 @@ find_old_style_renaming_symbol (const ch /* Strip the suffix if necessary. */ ada_remove_trailing_digits (function_name, &function_name_len); ada_remove_po_subprogram_suffix (function_name, &function_name_len); - ada_remove_Xbn_suffix (function_name, &function_name_len); + ada_remove_xbn_suffix (function_name, &function_name_len); /* Library-level functions are a special case, as GNAT adds a ``_ada_'' prefix to the function name to avoid namespace Index: src/gdb/addrmap.c =================================================================== RCS file: /cvs/src/src/gdb/addrmap.c,v retrieving revision 1.7 diff -u -p -r1.7 addrmap.c --- src/gdb/addrmap.c 1 Jan 2010 07:31:29 -0000 1.7 +++ src/gdb/addrmap.c 4 May 2010 22:14:56 -0000 @@ -491,7 +491,7 @@ splay_obstack_free (void *obj, void *clo /* Compare keys as CORE_ADDR * values. */ static int -splay_compare_CORE_ADDR_ptr (splay_tree_key ak, splay_tree_key bk) +splay_compare_core_addr_ptr (splay_tree_key ak, splay_tree_key bk) { CORE_ADDR a = * (CORE_ADDR *) ak; CORE_ADDR b = * (CORE_ADDR *) bk; @@ -519,7 +519,7 @@ addrmap_create_mutable (struct obstack * free list has to be initialized before we create the tree. */ map->free_nodes = NULL; - map->tree = splay_tree_new_with_allocator (splay_compare_CORE_ADDR_ptr, + map->tree = splay_tree_new_with_allocator (splay_compare_core_addr_ptr, NULL, /* no delete key */ NULL, /* no delete value */ splay_obstack_alloc, Index: src/gdb/hppa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.c,v retrieving revision 1.273 diff -u -p -r1.273 hppa-tdep.c --- src/gdb/hppa-tdep.c 19 Jan 2010 09:39:12 -0000 1.273 +++ src/gdb/hppa-tdep.c 4 May 2010 22:14:57 -0000 @@ -115,7 +115,7 @@ hppa_extract_5r_store (unsigned word) /* extract the immediate field from a {sr}sm instruction */ unsigned -hppa_extract_5R_store (unsigned word) +hppa_extract_5_r_store (unsigned word) { return (word >> 16 & MASK_5); } @@ -1390,17 +1390,17 @@ inst_saves_gr (unsigned long inst) || (inst >> 26) == 0x1f || ((inst >> 26) == 0x1f && ((inst >> 6) == 0xa))) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); /* Does it look like a std? */ if ((inst >> 26) == 0x1c || ((inst >> 26) == 0x03 && ((inst >> 6) & 0xf) == 0xb)) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); /* Does it look like a stwm? GCC & HPC may use this in prologues. */ if ((inst >> 26) == 0x1b) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); /* Does it look like sth or stb? HPC versions 9.0 and later use these too. */ @@ -1408,7 +1408,7 @@ inst_saves_gr (unsigned long inst) || ((inst >> 26) == 0x3 && (((inst >> 6) & 0xf) == 0x8 || (inst >> 6) & 0xf) == 0x9)) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); return 0; } @@ -1428,12 +1428,12 @@ inst_saves_fr (unsigned long inst) if ((inst & 0xfc00dfc0) == 0x2c001200) return hppa_extract_5r_store (inst); if ((inst & 0xfc000002) == 0x70000002) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); /* is this an FSTW ? */ if ((inst & 0xfc00df80) == 0x24001200) return hppa_extract_5r_store (inst); if ((inst & 0xfc000002) == 0x7c000000) - return hppa_extract_5R_store (inst); + return hppa_extract_5_r_store (inst); return 0; } Index: src/gdb/hppa-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.h,v retrieving revision 1.39 diff -u -p -r1.39 hppa-tdep.h --- src/gdb/hppa-tdep.h 1 Jan 2010 07:31:33 -0000 1.39 +++ src/gdb/hppa-tdep.h 4 May 2010 22:41:17 -0000 @@ -218,7 +218,7 @@ extern const struct objfile_data *hppa_o int hppa_get_field (unsigned word, int from, int to); int hppa_extract_5_load (unsigned int); -unsigned hppa_extract_5R_store (unsigned int); +unsigned hppa_extract_5_r_store (unsigned int); unsigned hppa_extract_5r_store (unsigned int); int hppa_extract_17 (unsigned int); int hppa_extract_21 (unsigned); Index: src/gdb/ia64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ia64-tdep.c,v retrieving revision 1.205 diff -u -p -r1.205 ia64-tdep.c --- src/gdb/ia64-tdep.c 1 Jan 2010 07:31:36 -0000 1.205 +++ src/gdb/ia64-tdep.c 4 May 2010 22:14:58 -0000 @@ -447,7 +447,7 @@ replace_bit_field (char *bundle, long lo and instruction bundle */ static long long -slotN_contents (char *bundle, int slotnum) +slotn_contents (char *bundle, int slotnum) { return extract_bit_field (bundle, 5+41*slotnum, 41); } @@ -455,7 +455,7 @@ slotN_contents (char *bundle, int slotnu /* Store an instruction in an instruction bundle */ static void -replace_slotN_contents (char *bundle, long long instr, int slotnum) +replace_slotn_contents (char *bundle, long long instr, int slotnum) { replace_bit_field (bundle, instr, 5+41*slotnum, 41); } @@ -534,7 +534,7 @@ fetch_instruction (CORE_ADDR addr, instr if (val != 0) return 0; - *instr = slotN_contents (bundle, slotnum); + *instr = slotn_contents (bundle, slotnum); template = extract_bit_field (bundle, 0, 5); *it = template_encoding_table[(int)template][slotnum]; @@ -705,12 +705,12 @@ ia64_memory_insert_breakpoint (struct gd reinserted by bp_loc_is_permanent. Multiple breakpoints at the same location cannot induce the internal error as they are optimized into a single instance by update_global_location_list. */ - instr_breakpoint = slotN_contents (bundle, slotnum); + instr_breakpoint = slotn_contents (bundle, slotnum); if (instr_breakpoint == IA64_BREAKPOINT) internal_error (__FILE__, __LINE__, _("Address %s already contains a breakpoint."), paddress (gdbarch, bp_tgt->placed_address)); - replace_slotN_contents (bundle, IA64_BREAKPOINT, slotnum); + replace_slotn_contents (bundle, IA64_BREAKPOINT, slotnum); bp_tgt->placed_size = bp_tgt->shadow_len; @@ -779,7 +779,7 @@ ia64_memory_remove_breakpoint (struct gd gdb_assert (bp_tgt->placed_size == BUNDLE_LEN - shadow_slotnum); gdb_assert (bp_tgt->placed_size == bp_tgt->shadow_len); - instr_breakpoint = slotN_contents (bundle_mem, slotnum); + instr_breakpoint = slotn_contents (bundle_mem, slotnum); if (instr_breakpoint != IA64_BREAKPOINT) { warning (_("Cannot remove breakpoint at address %s, " @@ -794,11 +794,11 @@ ia64_memory_remove_breakpoint (struct gd memcpy (bundle_saved, bundle_mem, BUNDLE_LEN); memcpy (bundle_saved + shadow_slotnum, bp_tgt->shadow_contents, bp_tgt->shadow_len); - instr_saved = slotN_contents (bundle_saved, slotnum); + instr_saved = slotn_contents (bundle_saved, slotnum); /* In BUNDLE_MEM, be careful to modify only the bits belonging to SLOTNUM and not any of the other ones that are stored in SHADOW_CONTENTS. */ - replace_slotN_contents (bundle_mem, instr_saved, slotnum); + replace_slotn_contents (bundle_mem, instr_saved, slotnum); val = target_write_memory (addr, bundle_mem, BUNDLE_LEN); do_cleanups (cleanup); @@ -862,9 +862,9 @@ ia64_breakpoint_from_pc (struct gdbarch /* A break instruction has its all its opcode bits cleared except for the parameter value. For L+X slot pair we are at the X slot (slot 2) so we should not touch the L slot - the upper 41 bits of the parameter. */ - instr_fetched = slotN_contents (bundle, slotnum); + instr_fetched = slotn_contents (bundle, slotnum); instr_fetched &= 0x1003ffffc0LL; - replace_slotN_contents (bundle, instr_fetched, slotnum); + replace_slotn_contents (bundle, instr_fetched, slotnum); return bundle + shadow_slotnum; } Index: src/gdb/procfs.c =================================================================== RCS file: /cvs/src/src/gdb/procfs.c,v retrieving revision 1.131 diff -u -p -r1.131 procfs.c --- src/gdb/procfs.c 20 Apr 2010 22:36:35 -0000 1.131 +++ src/gdb/procfs.c 4 May 2010 22:15:00 -0000 @@ -2974,7 +2974,7 @@ proc_set_watchpoint (procinfo *pi, CORE_ #include /* - * Function: proc_get_LDT_entry + * Function: proc_get_ldt_entry * * Inputs: * procinfo *pi; @@ -2987,7 +2987,7 @@ proc_set_watchpoint (procinfo *pi, CORE_ */ struct ssd * -proc_get_LDT_entry (procinfo *pi, int key) +proc_get_ldt_entry (procinfo *pi, int key) { static struct ssd *ldt_entry = NULL; #ifdef NEW_PROC_API @@ -3004,7 +3004,7 @@ proc_get_LDT_entry (procinfo *pi, int ke sprintf (pathname, "/proc/%d/ldt", pi->pid); if ((fd = open_with_retry (pathname, O_RDONLY)) < 0) { - proc_warn (pi, "proc_get_LDT_entry (open)", __LINE__); + proc_warn (pi, "proc_get_ldt_entry (open)", __LINE__); return NULL; } /* Make sure it gets closed again! */ @@ -3031,7 +3031,7 @@ proc_get_LDT_entry (procinfo *pi, int ke /* Get the number of LDT entries. */ if (ioctl (pi->ctl_fd, PIOCNLDT, &nldt) < 0) { - proc_warn (pi, "proc_get_LDT_entry (PIOCNLDT)", __LINE__); + proc_warn (pi, "proc_get_ldt_entry (PIOCNLDT)", __LINE__); return NULL; } @@ -3047,7 +3047,7 @@ proc_get_LDT_entry (procinfo *pi, int ke /* Read the whole table in one gulp. */ if (ioctl (pi->ctl_fd, PIOCLDT, ldt_entry) < 0) { - proc_warn (pi, "proc_get_LDT_entry (PIOCLDT)", __LINE__); + proc_warn (pi, "proc_get_ldt_entry (PIOCLDT)", __LINE__); return NULL; } @@ -3062,7 +3062,7 @@ proc_get_LDT_entry (procinfo *pi, int ke } /* - * Function: procfs_find_LDT_entry + * Function: procfs_find_ldt_entry * * Input: * ptid_t ptid; // The GDB-style pid-plus-LWP. @@ -3072,7 +3072,7 @@ proc_get_LDT_entry (procinfo *pi, int ke */ struct ssd * -procfs_find_LDT_entry (ptid_t ptid) +procfs_find_ldt_entry (ptid_t ptid) { gdb_gregset_t *gregs; int key; @@ -3081,14 +3081,14 @@ procfs_find_LDT_entry (ptid_t ptid) /* Find procinfo for the lwp. */ if ((pi = find_procinfo (PIDGET (ptid), TIDGET (ptid))) == NULL) { - warning (_("procfs_find_LDT_entry: could not find procinfo for %d:%ld."), + warning (_("procfs_find_ldt_entry: could not find procinfo for %d:%ld."), PIDGET (ptid), TIDGET (ptid)); return NULL; } /* get its general registers. */ if ((gregs = proc_get_gregs (pi)) == NULL) { - warning (_("procfs_find_LDT_entry: could not read gregs for %d:%ld."), + warning (_("procfs_find_ldt_entry: could not read gregs for %d:%ld."), PIDGET (ptid), TIDGET (ptid)); return NULL; } @@ -3096,7 +3096,7 @@ procfs_find_LDT_entry (ptid_t ptid) key = (*gregs)[GS] & 0xffff; /* Find the matching entry and return it. */ - return proc_get_LDT_entry (pi, key); + return proc_get_ldt_entry (pi, key); } #endif Index: src/gdb/remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.403 diff -u -p -r1.403 remote.c --- src/gdb/remote.c 3 May 2010 02:13:01 -0000 1.403 +++ src/gdb/remote.c 4 May 2010 22:15:03 -0000 @@ -1217,7 +1217,7 @@ enum Z_packet_type static enum auto_boolean remote_Z_packet_detect; static void -set_remote_protocol_Z_packet_cmd (char *args, int from_tty, +set_remote_protocol_z_packet_cmd (char *args, int from_tty, struct cmd_list_element *c) { int i; @@ -1229,7 +1229,7 @@ set_remote_protocol_Z_packet_cmd (char * } static void -show_remote_protocol_Z_packet_cmd (struct ui_file *file, int from_tty, +show_remote_protocol_z_packet_cmd (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { @@ -3482,7 +3482,7 @@ static char *remote_support_xml; /* Register string appended to "xmlRegisters=" in qSupported query. */ void -register_remote_support_xml (const char *xml ATTRIBUTE_UNUSED) +register_remote_support_xml (const char *xml) { #if defined(HAVE_LIBEXPAT) if (remote_support_xml == NULL) @@ -5612,7 +5612,7 @@ remote_prepare_to_store (struct regcache packet was not recognized. */ static int -store_register_using_P (const struct regcache *regcache, +store_register_using_p (const struct regcache *regcache, struct packet_reg *reg) { struct gdbarch *gdbarch = get_regcache_arch (regcache); @@ -5653,7 +5653,7 @@ store_register_using_P (const struct reg contents of the register cache buffer. FIXME: ignores errors. */ static void -store_registers_using_G (const struct regcache *regcache) +store_registers_using_g (const struct regcache *regcache) { struct remote_state *rs = get_remote_state (); struct remote_arch_state *rsa = get_remote_arch_state (); @@ -5709,7 +5709,7 @@ remote_store_registers (struct target_op possible; we often change only a small number of registers. Sometimes we change a larger number; we'd need help from a higher layer to know to use 'G'. */ - if (store_register_using_P (regcache, reg)) + if (store_register_using_p (regcache, reg)) return; /* For now, don't complain if we have no way to write the @@ -5719,15 +5719,15 @@ remote_store_registers (struct target_op if (!reg->in_g_packet) return; - store_registers_using_G (regcache); + store_registers_using_g (regcache); return; } - store_registers_using_G (regcache); + store_registers_using_g (regcache); for (i = 0; i < gdbarch_num_regs (get_regcache_arch (regcache)); i++) if (!rsa->regs[i].in_g_packet) - if (!store_register_using_P (regcache, &rsa->regs[i])) + if (!store_register_using_p (regcache, &rsa->regs[i])) /* See above for why we do not issue an error here. */ continue; } @@ -7387,7 +7387,7 @@ remote_remove_breakpoint (struct gdbarch } static int -watchpoint_to_Z_packet (int type) +watchpoint_to_z_packet (int type) { switch (type) { @@ -7411,7 +7411,7 @@ remote_insert_watchpoint (CORE_ADDR addr { struct remote_state *rs = get_remote_state (); char *p; - enum Z_packet_type packet = watchpoint_to_Z_packet (type); + enum Z_packet_type packet = watchpoint_to_z_packet (type); if (remote_protocol_packets[PACKET_Z0 + packet].support == PACKET_DISABLE) return 1; @@ -7444,7 +7444,7 @@ remote_remove_watchpoint (CORE_ADDR addr { struct remote_state *rs = get_remote_state (); char *p; - enum Z_packet_type packet = watchpoint_to_Z_packet (type); + enum Z_packet_type packet = watchpoint_to_z_packet (type); if (remote_protocol_packets[PACKET_Z0 + packet].support == PACKET_DISABLE) return -1; @@ -10445,8 +10445,8 @@ Set use of remote protocol `Z' packets") Show use of remote protocol `Z' packets "), _("\ When set, GDB will attempt to use the remote breakpoint and watchpoint\n\ packets."), - set_remote_protocol_Z_packet_cmd, - show_remote_protocol_Z_packet_cmd, /* FIXME: i18n: Use of remote protocol `Z' packets is %s. */ + set_remote_protocol_z_packet_cmd, + show_remote_protocol_z_packet_cmd, /* FIXME: i18n: Use of remote protocol `Z' packets is %s. */ &remote_set_cmdlist, &remote_show_cmdlist); add_prefix_cmd ("remote", class_files, remote_command, _("\ Index: src/gdb/sol-thread.c =================================================================== RCS file: /cvs/src/src/gdb/sol-thread.c,v retrieving revision 1.78 diff -u -p -r1.78 sol-thread.c --- src/gdb/sol-thread.c 1 Jan 2010 07:31:41 -0000 1.78 +++ src/gdb/sol-thread.c 4 May 2010 22:33:29 -0000 @@ -1107,11 +1107,11 @@ ps_pdmodel (gdb_ps_prochandle_t ph, int of libthread_db would fail because of ps_lgetLDT being undefined. */ ps_err_e -ps_lgetLDT (gdb_ps_prochandle_t ph, lwpid_t lwpid, +ps_lgetLDT (gdb_ps_prochandle_t ph, lwpid_t lwpid, /* ARI: editCase function */ struct ssd *pldt) { /* NOTE: only used on Solaris, therefore OK to refer to procfs.c. */ - extern struct ssd *procfs_find_LDT_entry (ptid_t); + extern struct ssd *procfs_find_ldt_entry (ptid_t); struct ssd *ret; /* FIXME: can't I get the process ID from the prochandle or @@ -1120,7 +1120,7 @@ ps_lgetLDT (gdb_ps_prochandle_t ph, lwpi if (PIDGET (inferior_ptid) <= 0 || lwpid <= 0) return PS_BADLID; - ret = procfs_find_LDT_entry (BUILD_LWP (lwpid, PIDGET (inferior_ptid))); + ret = procfs_find_ldt_entry (BUILD_LWP (lwpid, PIDGET (inferior_ptid))); if (ret) { memcpy (pldt, ret, sizeof (struct ssd)); Index: src/gdb/windows-nat.c =================================================================== RCS file: /cvs/src/src/gdb/windows-nat.c,v retrieving revision 1.208 diff -u -p -r1.208 windows-nat.c --- src/gdb/windows-nat.c 16 Apr 2010 07:49:35 -0000 1.208 +++ src/gdb/windows-nat.c 4 May 2010 22:15:04 -0000 @@ -2522,50 +2522,53 @@ _initialize_check_for_gdb_ini (void) } /* Define dummy functions which always return error for the rare cases where - these functions could not be found. */ + these functions could not be found. + Those functions mix upper and lowercase characters as they follow + the name in the windows API. + We use ARI comment to avoid a warining on A.R.I. page. */ static BOOL WINAPI -bad_DebugActiveProcessStop (DWORD w) +bad_DebugActiveProcessStop (DWORD w) /* ARI: editCase function */ { return FALSE; } static BOOL WINAPI -bad_DebugBreakProcess (HANDLE w) +bad_DebugBreakProcess (HANDLE w) /* ARI: editCase function */ { return FALSE; } static BOOL WINAPI -bad_DebugSetProcessKillOnExit (BOOL w) +bad_DebugSetProcessKillOnExit (BOOL w) /* ARI: editCase function */ { return FALSE; } static BOOL WINAPI -bad_EnumProcessModules (HANDLE w, HMODULE *x, DWORD y, LPDWORD z) +bad_EnumProcessModules (HANDLE w, HMODULE *x, DWORD y, LPDWORD z) /* ARI: editCase function */ { return FALSE; } #ifdef __USEWIDE static DWORD WINAPI -bad_GetModuleFileNameExW (HANDLE w, HMODULE x, LPWSTR y, DWORD z) +bad_GetModuleFileNameExW (HANDLE w, HMODULE x, LPWSTR y, DWORD z) /* ARI: editCase function */ { return 0; } #else static DWORD WINAPI -bad_GetModuleFileNameExA (HANDLE w, HMODULE x, LPSTR y, DWORD z) +bad_GetModuleFileNameExA (HANDLE w, HMODULE x, LPSTR y, DWORD z) /* ARI: editCase function */ { return 0; } #endif static BOOL WINAPI -bad_GetModuleInformation (HANDLE w, HMODULE x, LPMODULEINFO y, DWORD z) +bad_GetModuleInformation (HANDLE w, HMODULE x, LPMODULEINFO y, DWORD z) /* ARI: editCase function */ { return FALSE; } static BOOL WINAPI -bad_OpenProcessToken (HANDLE w, DWORD x, PHANDLE y) +bad_OpenProcessToken (HANDLE w, DWORD x, PHANDLE y) /* ARI: editCase function */ { return FALSE; }