From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17424 invoked by alias); 27 Mar 2013 08:54:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17398 invoked by uid 89); 27 Mar 2013 08:54:41 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT autolearn=no version=3.3.1 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.201.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 08:54:37 +0000 Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2R8sRnT059706 ; Wed, 27 Mar 2013 09:54:27 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms18.u-strasbg.fr [130.79.204.118]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2R8sQK2020369 ; Wed, 27 Mar 2013 09:54:27 +0100 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r2R8sPkc027586 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 27 Mar 2013 09:54:25 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" Cc: , , References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr> <83y5d9xrqt.fsf@gnu.org> In-Reply-To: <83y5d9xrqt.fsf@gnu.org> Subject: RE: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling Date: Wed, 27 Mar 2013 10:59:00 -0000 Message-ID: <005501ce2ac8$ae830150$0b8903f0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg01007.txt.bz2 Hi Eli, > > ChangeLog entry: > > > > 2013-03-26 Pierre Muller > > > > * windows-nat.c (handle_output_debug_string): Avoid typecast > > from integer of different size warning. > > > > > > Index: windows-nat.c > > =================================================================== > > RCS file: /cvs/src/src/gdb/windows-nat.c,v > > retrieving revision 1.245 > > diff -u -p -r1.245 windows-nat.c > > --- windows-nat.c 23 Mar 2013 10:48:23 -0000 1.245 > > +++ windows-nat.c 26 Mar 2013 21:39:57 -0000 > > @@ -990,7 +990,7 @@ handle_output_debug_string (struct targe > > retval = strtoul (p, &p, 0); > > if (!retval) > > retval = main_thread_id; > > - else if ((x = (LPCVOID) strtoull (p, NULL, 0)) > > + else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0)) > > && ReadProcessMemory (current_process_handle, x, > > &saved_context, > > __COPY_CONTEXT_SIZE, &n) > > Is the cast to LPCVOID really needed? What if you drop it (and not > add the cast to uintptr_t)? Without any cast, I get this warning: gcc -gstabs+ -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/l ocale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../ src/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclara tion-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Werror -c -o windows-n at.o -MT windows-nat.o -MMD -MP -MF .deps/windows-nat.Tpo ../../src/gdb/windows-nat.c cc1: warnings being treated as errors ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string': ../../src/gdb/windows-nat.c:993:16: erreur: assignment makes pointer from integer without a cast Makefile:972: recipe for target `windows-nat.o' failed make: *** [windows-nat.o] Error 1 Thus, I will commit the patch I proposed as Corinna already approved it. Pierre Muller