From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6797 invoked by alias); 26 Nov 2012 15:31:47 -0000 Received: (qmail 6789 invoked by uid 22791); 26 Nov 2012 15:31:45 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 15:31:36 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAQFVUYg056327 ; Mon, 26 Nov 2012 16:31:31 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAQFVU4u028497 ; Mon, 26 Nov 2012 16:31:30 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAQFVT5T032140 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 26 Nov 2012 16:31:29 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: , References: <20121126142036.10142.97678.stgit@brno.lan> <004401cdcbe4$524136c0$f6c3a440$@muller@ics-cnrs.unistra.fr> <50B38790.5090206@redhat.com> In-Reply-To: <50B38790.5090206@redhat.com> Subject: RE: [PATCH] Fix readlink calls in GDB Date: Mon, 26 Nov 2012 15:31:00 -0000 Message-ID: <005301cdcbeb$1b177e50$51467af0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00656.txt.bz2 I don't see any code setting the terminal char to '\0' in fbsd_pid_to_exec_file (fbsd-nat.c:40 rev 1.29) nor in linux_child_pid_to_exec_file (linux-nat.c:4311 rev 1.261) nor in nbsd_pid_to_exec_file (nbsd-nat.c:30 rev 1.10)... Maybe I am missing something... Pierre > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=C3=A9 : lundi 26 novembre 2012 16:15 > =C3=80 : Pierre Muller > Cc : gdb-patches@sourceware.org; rustyBSD@gmx.fr > Objet : Re: [PATCH] Fix readlink calls in GDB >=20 > On 11/26/2012 02:42 PM, Pierre Muller wrote: >=20 > > Just a question: > > your change doesn't seem to add the terminating '\0' > > in all the calls concerned, is this because it concerns specific > > native files for operating systems that already append the '\0' at the > end? >=20 > No. That must be done in all operating systems. If you look at the code > that surrounds the lines touched by the patch, you'll find the preexisting > code doing that. >=20 >=20 > -- > Pedro Alves