From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA 2/2] Remove old Cygwin1.5 support
Date: Wed, 06 Apr 2011 22:58:00 -0000 [thread overview]
Message-ID: <005101cbf4ae$1dca5fc0$595f1f40$@muller@ics-cnrs.unistra.fr> (raw)
Second part of the patch,
This part updates gdbserver/win32-low.c to use the
new cygwin_conv_path and cygwin_conv_path_list functions
in order to avoid build failure due to deprecated warning.
Christopher, is this patch acceptable as is?
Pierre Muller.
2011-04-07 Pierre Muller <muller@ics.u-strasbg.fr>
Remove support for old Cygwin 1.5 versions.
* win32-low.c (win32_create_inferior): Use new cygwin_path_list
function to avoid warning.
(win32_add_one_solib): Use cygwin_conv_path function to avoid
warning.
diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c
index b47081b..9cdd1b4 100644
--- a/gdb/gdbserver/win32-low.c
+++ b/gdb/gdbserver/win32-low.c
@@ -536,13 +536,15 @@ win32_create_inferior (char *program, char
**program_args)
path_ptr = getenv ("PATH");
if (path_ptr)
{
+ int len = cygwin_conv_path_list (CCP_POSIX_TO_WIN_A, path_ptr, NULL,
0);
orig_path = alloca (strlen (path_ptr) + 1);
- new_path = alloca (cygwin_posix_to_win32_path_list_buf_size
(path_ptr));
+ new_path = alloca (len);
strcpy (orig_path, path_ptr);
- cygwin_posix_to_win32_path_list (path_ptr, new_path);
+ cygwin_conv_path_list (CCP_POSIX_TO_WIN_A, path_ptr, new_path, len);
setenv ("PATH", new_path, 1);
- }
- cygwin_conv_to_win32_path (program, real_path);
+ }
+ cygwin_conv_path (CCP_POSIX_TO_WIN_A, program, real_path,
+ MAXPATHLEN);
program = real_path;
#endif
@@ -925,7 +927,7 @@ win32_add_one_solib (const char *name, CORE_ADDR
load_addr)
#endif
#ifdef __CYGWIN__
- cygwin_conv_to_posix_path (buf, buf2);
+ cygwin_conv_path (CCP_WIN_A_TO_POSIX, buf, buf2, sizeof (buf2));
#else
strcpy (buf2, buf);
#endif
next reply other threads:[~2011-04-06 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 22:58 Pierre Muller [this message]
2011-04-07 23:44 ` Pedro Alves
2011-04-08 0:01 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005101cbf4ae$1dca5fc0$595f1f40$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox