From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9930 invoked by alias); 17 Mar 2009 23:26:56 -0000 Received: (qmail 9917 invoked by uid 22791); 17 Mar 2009 23:26:56 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_05 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Mar 2009 23:26:51 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n2HNQmnW083100 ; Wed, 18 Mar 2009 00:26:48 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n2HNQmk7090733 ; Wed, 18 Mar 2009 00:26:48 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n2HNQls5036367 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 18 Mar 2009 00:26:47 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: , Subject: [RFA] fix bfd multi-arch compilation failure Date: Tue, 17 Mar 2009 23:59:00 -0000 Message-ID: <005001c9a757$db6bacb0$92430610$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00343.txt.bz2 Hi, I tried to do a compilation of gdb with --enable-targets=all --enable-64-bits-bfd on OpenSolaris 2008.11. I found two problems in bfd directory, related to uses of alloca without including I added #include garded by #ifdef HAVE_ALLOCA_H as I suppose that on some systems alloca is builtin and thus does not require any header. Is this OK to check in? Pierre Muller Pascal language support maintainer for GDB ChangeLog entry: 2009-03-18 Pierre Muller * elf32-m68hc1x.c: Add alloca header. * xsym.c: Ditto. Index: bfd/elf32-m68hc1x.c =================================================================== RCS file: /cvs/src/src/bfd/elf32-m68hc1x.c,v retrieving revision 1.33 diff -u -p -r1.33 elf32-m68hc1x.c --- bfd/elf32-m68hc1x.c 12 Mar 2008 08:36:59 -0000 1.33 +++ bfd/elf32-m68hc1x.c 17 Mar 2009 23:18:58 -0000 @@ -20,6 +20,9 @@ Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ +#ifdef HAVE_ALLOCA_H +#include +#endif #include "sysdep.h" #include "bfd.h" #include "bfdlink.h" Index: bfd/xsym.c =================================================================== RCS file: /cvs/src/src/bfd/xsym.c,v retrieving revision 1.23 diff -u -p -r1.23 xsym.c --- bfd/xsym.c 30 Jul 2008 04:34:56 -0000 1.23 +++ bfd/xsym.c 17 Mar 2009 23:18:58 -0000 @@ -23,6 +23,9 @@ #include "xsym.h" #include "bfd.h" #include "libbfd.h" +#ifdef HAVE_ALLOCA_H +#include +#endif #define bfd_sym_close_and_cleanup _bfd_generic_close_and_clea nup #define bfd_sym_bfd_free_cached_info _bfd_generic_bfd_free_cache d_info cvs diff: Diffing bfd/doc cvs diff: Diffing bfd/hosts cvs diff: Diffing bfd/po