From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15788 invoked by alias); 10 Sep 2010 16:09:49 -0000 Received: (qmail 15774 invoked by uid 22791); 10 Sep 2010 16:09:46 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,MSGID_MULTIPLE_AT,TW_TJ X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 16:09:39 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o8AG9PNq020358 ; Fri, 10 Sep 2010 18:09:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8AG9OZi003746 ; Fri, 10 Sep 2010 18:09:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8AG9OXu037169 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 10 Sep 2010 18:09:24 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <21924.6809640483$1284127133@news.gmane.org> In-Reply-To: Subject: RE: [RFA 2/5] New patches to support --enable-targets=all for mingw64 Date: Fri, 10 Sep 2010 19:02:00 -0000 Message-ID: <004f01cb5102$8dfe0350$a9fa09f0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00229.txt.bz2 > I think it is better to use SYMBOL_VALUE_BYTES here. > See how this field is set in mdebugread.c: >=20 > e =3D ((struct mdebug_extra_func_info *) > obstack_alloc (¤t_objfile->objfile_obstack, > sizeof (struct mdebug_extra_func_info))); > memset (e, 0, sizeof (struct mdebug_extra_func_info)); > SYMBOL_VALUE_BYTES (s) =3D (gdb_byte *) e; >=20 > This is ok with that change. OK, this way, no need for unitptr_t, as gdb_byte *=20 is already a host pointer. This is what I checked in, thanks for the approval, Pierre Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.12167 diff -u -p -r1.12167 ChangeLog --- ChangeLog 9 Sep 2010 23:04:46 -0000 1.12167 +++ ChangeLog 10 Sep 2010 16:03:15 -0000 @@ -1,3 +1,8 @@ +2010-09-10 Pierre Muller + + * alpha-mdebug-tdep.c (find_proc_desc): Use SYMBOL_VALUE_BYTES macro + before cast to pointer to avoid warning. + 2010-09-09 Kevin Buettner * v850-tdep.c (v850_gdbarch_init): Change the v850's `char' Index: alpha-mdebug-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/alpha-mdebug-tdep.c,v retrieving revision 1.25 diff -u -p -r1.25 alpha-mdebug-tdep.c --- alpha-mdebug-tdep.c 23 Apr 2010 15:14:22 -0000 1.25 +++ alpha-mdebug-tdep.c 10 Sep 2010 16:03:15 -0000 @@ -115,7 +115,7 @@ find_proc_desc (CORE_ADDR pc) if (sym) { - proc_desc =3D (struct mdebug_extra_func_info *) SYMBOL_VALUE (sym); + proc_desc =3D (struct mdebug_extra_func_info *) SYMBOL_VALUE_BYTES (= sym); /* Correct incorrect setjmp procedure descriptor from the library to make backtrace through setjmp work. */