Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Daniel Jacobowitz'" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] AR Index, remove yacc-lex sources for boolean tests
Date: Tue, 17 Mar 2009 23:26:00 -0000	[thread overview]
Message-ID: <004f01c9a751$d6f04570$84d0d050$@u-strasbg.fr> (raw)
In-Reply-To: <20090312163220.GB17979@caradoc.them.org>

I tried several times to commit that
approved patch, but I always get the same
error: Could not open lock file `/cvs/gdbadmin/ss/,gdb_ari.sh,'

I suppose that members allowed to commit to /cvs/src 
are not necessarily the same as for /cvs/gdbadmin...

Joel found out that this directory is writable only
by group  gdbadmin, and offered to commit it for me.

Thanks Joel,
the patch is below.


Pierre Muller
Pascal language support maintainer for GDB



PS: the commit.txt file was just for
the cvs commit -F commit.txt gdb_ari.sh
as this directory has no ChangeLog.



$ cat commit.txt
        * gdb_ari.sh (boolean, true, false): Do not consider lex and yacc
sources.

Pierre@d620-muller ~/ss
$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.77
diff -u -p -r1.77 gdb_ari.sh
--- gdb_ari.sh  24 Oct 2007 20:24:55 -0000      1.77
+++ gdb_ari.sh  17 Mar 2009 22:39:46 -0000
@@ -1364,7 +1364,9 @@ Do not use `boolean'\'',  use `int'\'' i
     category["boolean"] = ari_regression
 }
 /(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
-    fail("boolean")
+    if (is_yacc_or_lex == 0) {
+       fail("boolean")
+    }
 }

 BEGIN { doc["false"] = "\
@@ -1372,7 +1374,9 @@ Definitely do not use `false'\'' in bool
     category["false"] = ari_regression
 }
 /(^|[^_[:alnum:]])false([^_[:alnum:]]|$)/ {
-    fail("false")
+    if (is_yacc_or_lex == 0) {
+       fail("false")
+    }
 }

 BEGIN { doc["true"] = "\
@@ -1380,7 +1384,9 @@ Do not try to use `true'\'' in boolean e
     category["true"] = ari_regression
 }
 /(^|[^_[:alnum:]])true([^_[:alnum:]]|$)/ {
-    fail("true")
+    if (is_yacc_or_lex == 0) {
+       fail("true")
+    }
 }

 BEGIN { doc["if assignment"] = "\

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de 'Daniel Jacobowitz'
> Envoyé : Thursday, March 12, 2009 5:32 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] AR Index, remove yacc-lex sources for boolean tests
> 
> On Thu, Mar 12, 2009 at 11:29:26AM +0100, Pierre Muller wrote:
> >   This simple patch
> > avoids  testing lex and yacc files
> > for 'boolean' 'false' and 'true'.
> >
> >   Daniel, can I check this in?
> 
> Yes, go ahead.
> 
> --
> Daniel Jacobowitz
> CodeSourcery


  reply	other threads:[~2009-03-17 22:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 14:24 Pierre Muller
2009-03-12 17:47 ` 'Daniel Jacobowitz'
2009-03-17 23:26   ` Pierre Muller [this message]
2009-03-18  3:15     ` Joel Brobecker
2009-03-18  7:40       ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004f01c9a751$d6f04570$84d0d050$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox