From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28181 invoked by alias); 31 Mar 2010 13:38:14 -0000 Received: (qmail 28168 invoked by uid 22791); 31 Mar 2010 13:38:11 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=BAYES_20,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Mar 2010 13:38:05 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o2VDbmfm061672 ; Wed, 31 Mar 2010 15:37:49 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o2VDbmIl034696 ; Wed, 31 Mar 2010 15:37:48 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o2VDblQH063157 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 31 Mar 2010 15:37:47 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Mark Kettenis'" , Cc: References: <20100111160241.GA12356@host0.dyn.jankratochvil.net> <20100115003529.GA26561@host0.dyn.jankratochvil.net> <201001301305.o0UD56Zp003815@glazunov.sibelius.xs4all.nl> <20100130144723.GA9471@host0.dyn.jankratochvil.net> <201001311413.o0VEDJbY010431@glazunov.sibelius.xs4all.nl> In-Reply-To: <201001311413.o0VEDJbY010431@glazunov.sibelius.xs4all.nl> Subject: RE: [patch] Do not disappoint on "Create a core file of GDB?" Date: Wed, 31 Mar 2010 13:38:00 -0000 Message-ID: <004901cad0d7$5a4444d0$0eccce70$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01113.txt.bz2 Nevertheless, the patch http://sourceware.org/ml/gdb-cvs/2010-01/msg00131.html caused a re-entry of 'abort' rule in the ARI critical at http://sourceware.org/gdb/current/ari/ Because the script gdb_ari.sh expects exactly 4 occurences of abort() in gdb/utils.c source. As the fix is rather obvious (see below), I committed it as obvious. Pierre Muller=20 as ARI maintainer... (not very active on that part lately :(). =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.99 diff -c -r1.99 gdb_ari.sh *** gdb_ari.sh 6 Oct 2009 21:15:08 -0000 1.99 --- gdb_ari.sh 31 Mar 2010 13:27:38 -0000 *************** *** 637,643 **** BEGIN { doc["abort"] =3D "\ Do not use abort, instead use internal_error; GDB should never abort" category["abort"] =3D ari_regression ! fix("abort", "gdb/utils.c", 4) } /(^|[^_[:alnum:]])abort[[:space:]]*\(/ { fail("abort") --- 637,643 ---- BEGIN { doc["abort"] =3D "\ Do not use abort, instead use internal_error; GDB should never abort" category["abort"] =3D ari_regression ! fix("abort", "gdb/utils.c", 3) } /(^|[^_[:alnum:]])abort[[:space:]]*\(/ { fail("abort") > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Mark Kettenis > Envoy=E9=A0: Sunday, January 31, 2010 3:13 PM > =C0=A0: jan.kratochvil@redhat.com > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [patch] Do not disappoint on "Create a core file of GDB?" >=20 > > Date: Sat, 30 Jan 2010 15:47:23 +0100 > > From: Jan Kratochvil > > > > On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote: > > > I fear that after you did that the "NOTE: GDB has only three calls > to > > > abort()." comment is no longer true. > > > > There were four calls and there are three calls now. The message has > been > > updated: > > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=3Dsrc&r1=3D1.221&r2=3D1.222 > > + abort (); /* NOTE: GDB has only three calls to abort(). > */ > > - abort (); /* NOTE: GDB has only four calls to abort(). */ > > + abort (); /* NOTE: GDB has only three calls to abort(). */ > > - abort (); /* NOTE: GDB has only four calls to abort(). */ > > + abort (); /* NOTE: GDB has only three calls to abort(). > */ > > - abort (); /* NOTE: GDB has only four calls to abort(). > */ > > - abort (); /* NOTE: GDB has only four calls to abort(). > */ > > > > and current HEAD: > > $ grep 'GDB has only.*abort' * > > utils.c: abort (); /* NOTE: GDB has only three calls to > abort(). */ > > utils.c: abort (); /* NOTE: GDB has only three calls to abort(). > */ > > utils.c: abort (); /* NOTE: GDB has only three calls to > abort(). */ > > > > The ChangeLog entry > > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=3Dsrc&r1=3D1.11253&r2=3D1.1= 1254 > > describes thise "four"->"three" word change by: > > (internal_vproblem): Update the comment. > > which may have been insufficient, sorry. >=20 > Hmm, my diff-reading skills may have been affected by jetlag. Sorry > for the noise!