From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4524 invoked by alias); 11 Feb 2015 11:22:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4483 invoked by uid 89); 11 Feb 2015 11:22:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_05,MSGID_MULTIPLE_AT,UNWANTED_LANGUAGE_BODY autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.216) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Feb 2015 11:21:58 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 3D1E4141C79; Wed, 11 Feb 2015 12:21:55 +0100 (CET) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 2D8F9141C78; Wed, 11 Feb 2015 12:21:55 +0100 (CET) Received: from lmr.u-strasbg.fr (lmr3.u-strasbg.fr [172.30.21.3]) by mr6.u-strasbg.fr (Postfix) with ESMTP id 0B804141C81; Wed, 11 Feb 2015 12:21:52 +0100 (CET) Received: from lmr.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id D1ACDDA; Wed, 11 Feb 2015 12:21:52 +0100 (CET) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by lmr3.u-strasbg.fr (Postfix) with ESMTPSA id 8838B9D; Wed, 11 Feb 2015 12:21:50 +0100 (CET) From: "Pierre Muller" To: "'Doug Evans'" , References: In-Reply-To: Subject: RE: [PATCH] fix lib/pascal.exp dest snafu Date: Wed, 11 Feb 2015 11:22:00 -0000 Message-ID: <004801d045ec$eedb6b20$cc924160$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-02/txt/msg00300.txt.bz2 Hi Doug, > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Doug Evans > Envoy=E9=A0: mercredi 11 f=E9vrier 2015 07:18 > =C0=A0: gdb-patches@sourceware.org; pierre.muller@ics-cnrs.unistra.fr > Objet=A0: [PATCH] fix lib/pascal.exp dest snafu >=20 > The "dest" parameter to fpc_compile/gpc_compile is the name of > compilation destination file, not a board name. >=20 > This patch fixes this by using names consistent with > lib/future.exp:gdb_default_target_compile. Thank you very much for finding out this horrible mistake. Patch approved, Pierre Muller as pascal language maintainer. =20 > 2015-02-10 Doug Evans >=20 > * lib/pascal.exp (gpc_compile): Rename dest arg to destfile. > Fix dest parameter to board_info. > (fpc_compile): Ditto. > (gdb_compile_pascal): Rename dest arg to destfile. >=20 > diff --git a/gdb/testsuite/lib/pascal.exp > b/gdb/testsuite/lib/pascal.exp > index 994e3da..89b552d 100644 > --- a/gdb/testsuite/lib/pascal.exp > +++ b/gdb/testsuite/lib/pascal.exp > @@ -68,9 +68,11 @@ proc pascal_init {} { > set pascal_init_done 1 > } >=20 > -proc gpc_compile {source dest type options} { > +proc gpc_compile {source destfile type options} { > global gpc_compiler > set add_flags "" > + set dest [target_info name] > + > if {$type =3D=3D "object"} { > append add_flags " -c" > } > @@ -93,13 +95,15 @@ proc gpc_compile {source dest type options} { > } > } >=20 > - set result [remote_exec host $gpc_compiler "-o $dest --automake > $add_flags $source"] > + set result [remote_exec host $gpc_compiler "-o $destfile -- > automake $add_flags $source"] > return $result > } >=20 > -proc fpc_compile {source dest type options} { > +proc fpc_compile {source destfile type options} { > global fpc_compiler > set add_flags "" > + set dest [target_info name] > + > if {$type =3D=3D "object"} { > append add_flags " -Cn" > } > @@ -122,11 +127,11 @@ proc fpc_compile {source dest type options} { > } > } >=20 > - set result [remote_exec host $fpc_compiler "-o$dest $add_flags > $source"] > + set result [remote_exec host $fpc_compiler "-o$destfile $add_flags > $source"] > return $result > } >=20 > -proc gdb_compile_pascal {source dest type options} { > +proc gdb_compile_pascal {source destfile type options} { > global pascal_init_done > global pascal_compiler_is_gpc > global pascal_compiler_is_fpc > @@ -136,15 +141,15 @@ proc gdb_compile_pascal {source dest type > options} { > } >=20 > if { $pascal_compiler_is_fpc =3D=3D 1 } { > - set result [fpc_compile $source $dest $type $options] > + set result [fpc_compile $source $destfile $type $options] > } elseif { $pascal_compiler_is_gpc =3D=3D 1 } { > - set result [gpc_compile $source $dest $type $options] > + set result [gpc_compile $source $destfile $type $options] > } else { > unsupported "No pascal compiler found" > return "No pascal compiler. Compilation failed." > } >=20 > - if ![file exists $dest] { > + if ![file exists $destfile] { > unsupported "Pascal compilation failed: $result" > return "Pascal compilation failed." > }