From: "Michael Snyder" <msnyder@sonic.net>
To: "Daniel Jacobowitz" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] unfreed memory in cli_command_loop
Date: Sun, 01 Jul 2007 15:50:00 -0000 [thread overview]
Message-ID: <004401c7bbf7$8a7b4880$677ba8c0@sonic.net> (raw)
In-Reply-To: <20070701153828.GB10872@caradoc.them.org>
> On Thu, Jun 28, 2007 at 07:05:32PM -0700, Michael Snyder wrote:
> > Minor memory leak. I checked to make sure that readline makes
> > and keeps its own copy of this string, so it's OK for us to
> > free our copy.
>
> Seems fine, but I'm not really sure when that cleanup is going to be
> called. We're outside the command loop here so it hasn't recorded a
> watermark to clean back to. Does it ever get run? If not, you could
> use alloca and avoid the whole issue.
Whoa, you're right, thanks for the catch.
next prev parent reply other threads:[~2007-07-01 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 2:17 msnyder
2007-07-01 15:39 ` Daniel Jacobowitz
2007-07-01 15:50 ` Michael Snyder [this message]
2007-07-03 1:56 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004401c7bbf7$8a7b4880$677ba8c0@sonic.net' \
--to=msnyder@sonic.net \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox