From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31237 invoked by alias); 30 Mar 2011 21:34:22 -0000 Received: (qmail 31094 invoked by uid 22791); 30 Mar 2011 21:34:18 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Mar 2011 21:33:21 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2ULXJS3035109 for ; Wed, 30 Mar 2011 23:33:19 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [130.79.204.11]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2ULWnv7039010 ; Wed, 30 Mar 2011 23:32:49 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2ULWfNn017625 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 30 Mar 2011 23:32:48 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" Cc: References: <00ba01cbeed2$bbf50150$33df03f0$%muller@ics-cnrs.unistra.fr> <83ipv0qtl5.fsf@gnu.org> In-Reply-To: <83ipv0qtl5.fsf@gnu.org> Subject: RE: [RFC 9/9] Unify windows specifics into common/windows-hdep files Date: Wed, 30 Mar 2011 21:34:00 -0000 Message-ID: <004201cbef22$04834770$0d89d650$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01210.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Eli Zaretskii > Envoy=E9=A0: mercredi 30 mars 2011 21:47 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC 9/9] Unify windows specifics into common/windows-hdep files >=20 > > From: "Pierre Muller" > > Date: Wed, 30 Mar 2011 14:05:17 +0200 > > > > if (strcasecmp (buf, "ntdll.dll") =3D=3D 0) > > { > > - GetSystemDirectory (buf, sizeof (buf)); > > + GetSystemDirectoryA (buf, sizeof (buf)); >=20 > This will be a problem if we ever support a _UNICODE build. No because buf always a char array in the code and thus require the use of GetSystemDirectoryA function even if Unicode functions are used elsewhere. > > + if (windows_conv_path (WINDOWS_POSIX_TO_NATIVE, exec_file, > real_path, > > + __PMAX * sizeof (win_buf_t)) < 0) > > error (_("Error starting executable: %d"), errno); >=20 > But windows_conv_path never returns a negative value, it returns zero > if it fails. At least for Cygwin, windows_conv_path simply returns cygwinconv_path result, his is why I didn't change the code arounf it: I agree that I need to improve the mingw part of that function according to your comments for RFC 1/9. =20 > Thanks. Thank you for your comments Pierre