From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28861 invoked by alias); 7 Apr 2011 22:27:16 -0000 Received: (qmail 28852 invoked by uid 22791); 7 Apr 2011 22:27:15 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Apr 2011 22:27:10 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p37MR403071451 ; Fri, 8 Apr 2011 00:27:04 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms7.u-strasbg.fr [130.79.204.16]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p37MR3IG055699 ; Fri, 8 Apr 2011 00:27:03 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p37MR1fb040448 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 8 Apr 2011 00:27:02 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: "'Pedro Alves'" References: <004e01cbf4ae$1cea8710$56bf9530$@muller@ics-cnrs.unistra.fr> <20110407212438.GA18550@ednor.casa.cgf.cx> In-Reply-To: <20110407212438.GA18550@ednor.casa.cgf.cx> Subject: RE: [RFA 1/2] Remove old Cygwin1.5 support Date: Thu, 07 Apr 2011 22:27:00 -0000 Message-ID: <004101cbf572$eceb1fa0$c6c15ee0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00115.txt.bz2 > >The first two patches concern the removal of Cygwin 1.5 support has he > >suggested. This allows some simplifications in windows-nat.c code > >and I will try to further reduce cygwin/mingw differences in subsequent > >patches. > > > >This first part just removes the macros that are used to support Cygwin 1.5 > >in remote-fileio.c and windows-nat.c > >The second part updates gdbserver/win32-low.c to use the > >new cygwin_conv_path and cygwin_conv_path_list functions > >in order to avoid build failure due to deprecated warning. > > > >Does anyone object to the idea of removing old Cygwin support? > >Christopher, is this patch acceptable as is? > > > >Pierre Muller. > > > >2011-04-07 Pierre Muller > > > > Remove support for old Cygwin 1.5 versions. > > * remote-fileio.c: Remove macros used to emulate new > >cygwin_conv_path > > function on old Cygwin version. > > * windows-nat.c: Remove cygwin version check and always define > > __USEWIDE for Cygwin compilation. > > Looks good. Please check in. Thanks for the approval, patch checked in. > I can't approve the gdbserver patch since > I don't believe I have that privilege. Maybe Pedro can? Patch is in: http://sourceware.org/ml/gdb-patches/2011-04/msg00100.html Pierre Muller