From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31649 invoked by alias); 7 Jan 2009 13:54:33 -0000 Received: (qmail 31640 invoked by uid 22791); 7 Jan 2009 13:54:31 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_05 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 13:54:26 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n07DrnQ4035477 ; Wed, 7 Jan 2009 14:53:49 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n07DrnDh053053 ; Wed, 7 Jan 2009 14:53:49 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n07DrlhX096432 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 7 Jan 2009 14:53:47 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Kai Tietz'" , "'Joel Brobecker'" Cc: References: <20090107122701.GJ1751@adacore.com> In-Reply-To: Subject: RE: [patch] Reading coff-pe-read files Date: Wed, 07 Jan 2009 13:54:00 -0000 Message-ID: <004101c970cf$5ee27390$1ca75ab0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00096.txt.bz2 Should this be transformed so that we can also correctly cross-read 64-bit PE files on 32-bit and vice-versa? Possibly by defining an extra offset that would be set to 16 if target is "pe-x86-64" or "pei-x86-64" and to zero otherwise? Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Kai Tietz > Envoy=E9=A0: Wednesday, January 07, 2009 2:15 PM > =C0=A0: Joel Brobecker > Cc=A0: gdb-patches@sourceware.org > Objet=A0: [patch] Reading coff-pe-read files >=20 > Hi, >=20 > One small piece for x86_64 windows support in coff-pe-read.c seems to > be missing. In function read_pe_exported_syms wrong indexes are used to > find exports of the image. > The source uses here the same pattern as in bfd/pe-dll.c. >=20 > ChangeLog >=20 > 2009-01-07 Kai Tietz >=20 > * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+ > export directory. >=20 >=20 > I am uncertain, which macro I should use here (or if it would be better > to > make for PE+ a copy of this file), so I used _WIN64 as condition. >=20 > Cheers, > Kai >=20 > PS: I have already papers ready with FSF for gdb, so there shouldn't be > any problem about taking parts of my donated code, I've provided to > Joel > IMHO. >=20 >=20 >=20 > | (\_/) This is Bunny. Copy and paste Bunny > | (=3D'.'=3D) into your signature to help him gain > | (")_(") world domination.