From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13313 invoked by alias); 19 Nov 2010 08:10:47 -0000 Received: (qmail 13296 invoked by uid 22791); 19 Nov 2010 08:10:41 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 08:10:36 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id oAJ8ALpI000804 ; Fri, 19 Nov 2010 09:10:21 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAJ8AJOA021682 ; Fri, 19 Nov 2010 09:10:19 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAJ8AGxV043390 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 19 Nov 2010 09:10:17 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Richard Earnshaw'" Cc: "'Daniel Jacobowitz'" , "'Ulrich Weigand'" , References: <002701cb83f6$30b394e0$921abea0$@muller@ics-cnrs.unistra.fr> <20101116000346.GN8573@caradoc.them.org> <000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr> <1290086858.18751.21.camel@e102346-lin.cambridge.arm.com> <002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr> <1290088588.7919.1.camel@e102346-lin.cambridge.arm.com> In-Reply-To: <1290088588.7919.1.camel@e102346-lin.cambridge.arm.com> Subject: RE: [RFA] About arm-tdep.c arm_in_function_epilogue_p function Date: Fri, 19 Nov 2010 08:10:00 -0000 Message-ID: <003f01cb87c1$352d4bf0$9f87e3d0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00253.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Richard Earnshaw > Envoy=E9=A0: jeudi 18 novembre 2010 14:56 > =C0=A0: Pierre Muller > Cc=A0: 'Daniel Jacobowitz'; 'Ulrich Weigand'; gdb-patches@sourceware.org > Objet=A0: Re: [RFA] About arm-tdep.c arm_in_function_epilogue_p function >=20 >=20 > On Thu, 2010-11-18 at 14:43 +0100, Pierre Muller wrote: > > OK, here is the patch. > > > > As already said, this patch doesn't change anything on > > the testsuite results for a armv7l linux machine. > > > > > Why don't you just post a patch? Then we can assess it as we would > all > > > other patches. The comments in the code at this point clearly > don't > > > match the code, so something certainly needs fixing. > > > > > > R. > > >=20 > Looking at a wider context I think I see what's happened. The block > here is essentially a copy of the block earlier in the function with > s/pc/sp/ applied. Except this one variable wasn't updated properly. >=20 > OK. Thank you for the approval, patch committed: http://sourceware.org/ml/gdb-cvs/2010-11/msg00088.html Pierre