From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2467 invoked by alias); 20 Jun 2010 17:02:40 -0000 Received: (qmail 2243 invoked by uid 22791); 20 Jun 2010 17:02:39 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jun 2010 17:02:33 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o5KH1vI4008515 ; Sun, 20 Jun 2010 19:01:57 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms4.u-strasbg.fr [IPv6:2001:660:2402:d::13]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o5KH1uiT048210 ; Sun, 20 Jun 2010 19:01:56 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o5KH1suJ019104 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Sun, 20 Jun 2010 19:01:54 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Doug Evans'" Cc: "'Hui Zhu'" , , "'Pedro Alves'" , "'Stan Shebs'" , "'Eli Zaretskii'" , , "'Michael Snyder'" References: <201006071700.28706.pedro@codesourcery.com> <4C19222C.2000208@codesourcery.com> <201006162016.18181.pedro@codesourcery.com> <4C19265B.7090502@codesourcery.com> <4C1A6362.3020306@vmware.com> <-3945058798826177264@unknownmsgid> In-Reply-To: Subject: RE: [RFA-new version][gdbserver] x86 agent expression bytecode compiler (speed up conditional tracepoints) Date: Sun, 20 Jun 2010 17:02:00 -0000 Message-ID: <003f01cb109a$4f5c2d00$ee148700$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00442.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Doug Evans > Envoy=E9=A0: Sunday, June 20, 2010 5:31 PM > =C0=A0: Pierre Muller > Cc=A0: Hui Zhu; gdb-patches@sourceware.org; Pedro Alves; Stan Shebs; Eli > Zaretskii; tromey@redhat.com; Michael Snyder > Objet=A0: Re: [RFA-new version][gdbserver] x86 agent expression bytecode > compiler (speed up conditional tracepoints) >=20 > On Sun, Jun 20, 2010 at 2:29 AM, Pierre Muller > wrote: > > =A0As I said in a previous email, Ian's patch didn't work for me. > > http://sourceware.org/ml/gdb-patches/2010-06/msg00424.html >=20 > That's weird. > Ian's approach involves removing the "if-always-true" test completely > leaving just an asm. > Can you send me the patch of Ian's that you tried? I probably did a mistake indeed in my first try. As it was not a patch to apply, I just modify the source directly, and I suppose that I added the `do while (0)', but forgot to remove the 'if (always_true ()) ' part, which would explain why it works now and failed when I tried first... Sorry about that false alarm... Consider my RFA as withdrawn (see below), but please it would be nice to get ASAP a patch in=20 that allows again to use the standard gdb_tester.sh script. I cannot test any patch currently on gcc16 because gdbserver compilation always fails. > > =A0I propose here another small patch that fixes the linking failure. > > Using a volatile variable, it explicitly forbids the compiler > > to optimize out code by forbidding the assumption that this value > will > > never change. > > > > =A0This works on gcc16, an the approach seems reasonable. >=20 > That's my patch. :-) Sorry, I didn't read the whole thread, as I am not really interested in this fast tracepoint feature. =20 > http://sourceware.org/ml/gdb-patches/2010-06/msg00374.html Sorry for resubmitting a patch same as your, but at least it is as if I voted for your patch too! Pierre