From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10148 invoked by alias); 26 Sep 2012 21:31:12 -0000 Received: (qmail 10134 invoked by uid 22791); 26 Sep 2012 21:31:10 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_40,FSL_RCVD_USER,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 21:30:50 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q8QLUj0H069101 ; Wed, 26 Sep 2012 23:30:45 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms13.u-strasbg.fr [130.79.204.113]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q8QLUjWM016213 ; Wed, 26 Sep 2012 23:30:45 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q8QLUg7n029643 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 26 Sep 2012 23:30:43 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <18620.4427075156$1348564388@news.gmane.org> <87a9wcy2no.fsf@fleche.redhat.com> In-Reply-To: <87a9wcy2no.fsf@fleche.redhat.com> Subject: RE: [RFA] Add missing gdb_bfd.h includes Date: Wed, 26 Sep 2012 21:31:00 -0000 Message-ID: <003d01cd9c2e$31375170$93a5f450$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00608.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: mercredi 26 septembre 2012 22:01 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Add missing gdb_bfd.h includes >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> Is this OK? >=20 > Yes, thank you. OK, patch committed in http://sourceware.org/ml/gdb-cvs/2012-09/msg00156.html =20 > Pierre> As usual, > Pierre> 1) I am not sure about correct wording for ChangeLog >=20 > What you wrote is fine. >=20 > Pierre> 2) I never really understood the ordering logic (or to > Pierre> be more precise, if there is an ordering logic) of C headers > Pierre> in C source files, thus I inserted them more or less randomly... >=20 > There should not be many strong ordering dependencies in gdb, aside from > the rule that defs.h has to come first. I wouldn't worry about it in > general. Thanks for the clarification, Pierre=20 =20