From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28383 invoked by alias); 4 May 2010 16:05:08 -0000 Received: (qmail 28164 invoked by uid 22791); 4 May 2010 16:05:05 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,SARE_SUB_GETRID,TW_BL,TW_EG X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 16:04:59 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44G4Yjq031242 ; Tue, 4 May 2010 18:04:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o44G4YOk074254 ; Tue, 4 May 2010 18:04:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44G4Ybi009226 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 4 May 2010 18:04:34 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: , References: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr> <20100504153752.GJ2768@adacore.com> In-Reply-To: <20100504153752.GJ2768@adacore.com> Subject: [RFA] Get rid of ATTRIBUTE_UNUSED in gdb sources Date: Tue, 04 May 2010 16:05:00 -0000 Message-ID: <003d01caeba3$7ff10920$7fd31b60$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00071.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Tuesday, May 04, 2010 5:38 PM > =C0=A0: Pierre Muller > Cc=A0: gdb@sourceware.org; gdb-patches@sourceware.org > Objet=A0: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources >=20 > > Is this comment still valid, from the compiler point of view? > > Does gcc still have such problems? >=20 > I don't know. >=20 > > If yes, is it OK if I remove all ATTRIBUTE_UNUSED from sources? > > If no, shouldn't we change that policy? >=20 > I haven't thought much about it but, to me ATTRIBUTE_UNUSED does not > make sense unless we use -Wunused-param. And I really don't see how > this switch could help us increase code quality - only extra hassle > trying to silence warnings. We have so many functions used as callbacks > with defined APIs that we probably have unused parameters everywhere. > So, at this point, I'm leaning towards getting rid of ATTRIBUTE_UNUSED > and keeping the ARI (or perhaps poison it too). In that case, may I commit the following? Tested on gcc16, no changes found. Pierre=20=20 2010-05-04 Pierre Muller ARI fix: Remove ATTRIBUTE_UNUSED throughout. * arm-linux-tdep.c (arm_linux_cleanup_svc): Remove=20 ATTRIBUTE_UNUSED. (cleanup_kernel_helper_return): Likewise. * arm-tdep.c (copy_unmodified): Likewise. (copy_preload): Likewise. (copy_copro_load_store): Likewise. (cleanup_branch): Likewise. (copy_b_bl_blx): Likewise. (copy_bx_blx_reg): Likewise. (copy_alu_imm): Likewise. (copy_alu_reg): Likewise. (copy_alu_shifted_reg): Likewise. (cleanup_load): Likewise. (cleanup_store): Likewise. (cleanup_block_load_pc): Likewise. (cleanup_svc): Likewise. (copy_undef): Likewise. (copy_unpred): Likewise. * remote.c (register_remote_support_xml): Likewise. Index: src/gdb/arm-linux-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/arm-linux-tdep.c,v retrieving revision 1.75 diff -u -p -r1.75 arm-linux-tdep.c --- src/gdb/arm-linux-tdep.c 29 Apr 2010 16:34:25 -0000 1.75 +++ src/gdb/arm-linux-tdep.c 4 May 2010 15:45:39 -0000 @@ -655,7 +655,7 @@ arm_linux_software_single_step (struct f /* Support for displaced stepping of Linux SVC instructions. */ =20 static void -arm_linux_cleanup_svc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +arm_linux_cleanup_svc (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { @@ -776,7 +776,7 @@ arm_linux_copy_svc (struct gdbarch *gdba would have been called from the non-displaced location). */ =20 static void -cleanup_kernel_helper_return (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_kernel_helper_return (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { Index: src/gdb/arm-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/arm-tdep.c,v retrieving revision 1.302 diff -u -p -r1.302 arm-tdep.c --- src/gdb/arm-tdep.c 31 Mar 2010 22:10:07 -0000 1.302 +++ src/gdb/arm-tdep.c 4 May 2010 15:45:40 -0000 @@ -3702,7 +3702,7 @@ insn_references_pc (uint32_t insn, uint3 matter what address they are executed at: in those cases, use this. */ =20 static int -copy_unmodified (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, +copy_unmodified (struct gdbarch *gdbarch, uint32_t insn, const char *iname, struct displaced_step_closure *dsc) { if (debug_displaced) @@ -3718,7 +3718,7 @@ copy_unmodified (struct gdbarch *gdbarch /* Preload instructions with immediate offset. */ =20 static void -cleanup_preload (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_preload (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { displaced_write_reg (regs, dsc, 0, dsc->tmp[0], CANNOT_WRITE_PC); @@ -3803,7 +3803,7 @@ copy_preload_reg (struct gdbarch *gdbarc /* Copy/cleanup coprocessor load and store instructions. */ =20 static void -cleanup_copro_load_store (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_copro_load_store (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { @@ -3857,7 +3857,7 @@ copy_copro_load_store (struct gdbarch *g PC). */ =20 static void -cleanup_branch (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, +cleanup_branch (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { ULONGEST from =3D dsc->insn_addr; @@ -3881,7 +3881,7 @@ cleanup_branch (struct gdbarch *gdbarch=20 /* Copy B/BL/BLX instructions with immediate destinations. */ =20 static int -copy_b_bl_blx (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, +copy_b_bl_blx (struct gdbarch *gdbarch, uint32_t insn, struct regcache *regs, struct displaced_step_closure *dsc) { unsigned int cond =3D bits (insn, 28, 31); @@ -3928,7 +3928,7 @@ copy_b_bl_blx (struct gdbarch *gdbarch A /* Copy BX/BLX with register-specified destinations. */ =20 static int -copy_bx_blx_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, +copy_bx_blx_reg (struct gdbarch *gdbarch, uint32_t insn, struct regcache *regs, struct displaced_step_closure *dsc) { unsigned int cond =3D bits (insn, 28, 31); @@ -3966,7 +3966,7 @@ copy_bx_blx_reg (struct gdbarch *gdbarch /* Copy/cleanup arithmetic/logic instruction with immediate RHS. */ =20 static void -cleanup_alu_imm (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_alu_imm (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { ULONGEST rd_val =3D displaced_read_reg (regs, dsc->insn_addr, 0); @@ -4027,7 +4027,7 @@ copy_alu_imm (struct gdbarch *gdbarch, u /* Copy/cleanup arithmetic/logic insns with register RHS. */ =20 static void -cleanup_alu_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_alu_reg (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { ULONGEST rd_val; @@ -4096,7 +4096,7 @@ copy_alu_reg (struct gdbarch *gdbarch, u /* Cleanup/copy arithmetic/logic insns with shifted register RHS. */ =20 static void -cleanup_alu_shifted_reg (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_alu_shifted_reg (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { @@ -4170,7 +4170,7 @@ copy_alu_shifted_reg (struct gdbarch *gd /* Clean up load instructions. */ =20 static void -cleanup_load (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, +cleanup_load (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { ULONGEST rt_val, rt_val2 =3D 0, rn_val; @@ -4200,7 +4200,7 @@ cleanup_load (struct gdbarch *gdbarch AT /* Clean up store instructions. */ =20 static void -cleanup_store (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, +cleanup_store (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { CORE_ADDR from =3D dsc->insn_addr; @@ -4533,7 +4533,7 @@ cleanup_block_store_pc (struct gdbarch * must undo that here. */ =20 static void -cleanup_block_load_pc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, +cleanup_block_load_pc (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { @@ -4729,7 +4729,7 @@ copy_block_xfer (struct gdbarch *gdbarch for Linux, where some SVC instructions must be treated specially. */ =20 static void -cleanup_svc (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, struct regcache *regs, +cleanup_svc (struct gdbarch *gdbarch, struct regcache *regs, struct displaced_step_closure *dsc) { CORE_ADDR from =3D dsc->insn_addr; @@ -4773,7 +4773,7 @@ copy_svc (struct gdbarch *gdbarch, uint3 /* Copy undefined instructions. */ =20 static int -copy_undef (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, +copy_undef (struct gdbarch *gdbarch, uint32_t insn, struct displaced_step_closure *dsc) { if (debug_displaced) @@ -4788,7 +4788,7 @@ copy_undef (struct gdbarch *gdbarch ATTR /* Copy unpredictable instructions. */ =20 static int -copy_unpred (struct gdbarch *gdbarch ATTRIBUTE_UNUSED, uint32_t insn, +copy_unpred (struct gdbarch *gdbarch, uint32_t insn, struct displaced_step_closure *dsc) { if (debug_displaced) Index: src/gdb/remote.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.403 diff -u -p -r1.403 remote.c --- src/gdb/remote.c 3 May 2010 02:13:01 -0000 1.403 +++ src/gdb/remote.c 4 May 2010 15:45:42 -0000 @@ -3482,7 +3482,7 @@ static char *remote_support_xml; /* Register string appended to "xmlRegisters=3D" in qSupported query. */ =20 void -register_remote_support_xml (const char *xml ATTRIBUTE_UNUSED) +register_remote_support_xml (const char *xml) { #if defined(HAVE_LIBEXPAT) if (remote_support_xml =3D=3D NULL)