From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24532 invoked by alias); 16 May 2012 07:42:42 -0000 Received: (qmail 24521 invoked by uid 22791); 16 May 2012 07:42:40 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 May 2012 07:42:13 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4G7gAW3008981 for ; Wed, 16 May 2012 09:42:11 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4G7gAge002940 for ; Wed, 16 May 2012 09:42:10 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4G7gAfj003246 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Wed, 16 May 2012 09:42:10 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFC] Add ARI directory to gdb sources Date: Wed, 16 May 2012 07:42:00 -0000 Message-ID: <003901cd3337$66ac7b10$34057130$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00597.txt.bz2 We recently had a discussion about integrating gdb_ari.sh script into gdb sources directly. See: http://sourceware.org/ml/gdb-patches/2012-04/msg00834.html Currently the ARI (Awk Regression Index) script is a separate cvs checkout and is used to generate three type of ARI reports: Last release ARI: http://sourceware.org/gdb/download/ari/ generated normally in the release process. daily run for current cvs trunk: http://sourceware.org/gdb/current/ari/ daily run for most recent branch: http://sourceware.org/gdb/ari/ The idea behind moving gdb_ari.sh script into gdb sources would be: 1) Be able to adapt this script to changes in the gdb sources. Example: Currently, there are 14 types of critical bugs (corresponding to previously eliminated problems that resurfaced). These are mostly due to some functions that should not generally be used in the gdb sources (like xasprintf function) but are present at specific locations: BEGIN { doc["xasprintf"] = "\ Do not use xasprintf(), instead use xstrprintf" fix("xasprintf", "gdb/defs.h", 1) fix("xasprintf", "gdb/utils.c", 1) category["xasprintf"] = ari_regression } /(^|[^_[:alnum:]])xasprintf[[:space:]]*\(/ { fail("xasprintf") } This means that xasprintf function should appear only two type in the whole gdb sources, once in defs.gh and once in utils.c. But recent changes (moves of some functions to common subdirectory), lead to the fact that xasprintf is now referenced in common/common-utils.h and common/common-utils.c This is of course not a real problem, but changing this in the gdb_ari.sh script would mean that this script would give wrong information if run on older gdb sources. 2) The second reason was to allow developers or any person that wants to analyze gdb sources to run this script. The question of the location where we should add this script in gdb source arose. Joel suggested to put it directly into gdb directory. But after looking at the suggestion, it appears that you can't just use gdb_ari.sh alone, the update-web-ari script also uses gdb_find.sh script for instance, and a modified version of this update-web-air should probably also be added. Thus I would rather suggest to add a new directory called ari. Suggestions and comments most welcomed, Pierre Muller GDB pascal language maintainer writing as unofficial ARI maitainer