From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15232 invoked by alias); 18 Apr 2009 22:52:01 -0000 Received: (qmail 15218 invoked by uid 22791); 18 Apr 2009 22:52:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_SUB_PCT_LETTER X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Apr 2009 22:51:54 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n3IMpo3V017359 for ; Sun, 19 Apr 2009 00:51:50 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n3IMpoFn043701 for ; Sun, 19 Apr 2009 00:51:50 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n3IMpnAC017245 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Sun, 19 Apr 2009 00:51:50 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFA] ARI fix: remove 6 last %p occurences Date: Sat, 18 Apr 2009 22:52:00 -0000 Message-ID: <003601c9c078$44881fb0$cd985f10$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00492.txt.bz2 This second patch would remove "%p" in printf-like function. I apparently missed ia64-tdep.c completely on my previous patch, do know why. The two last changes in symmisc.c were postponed in my first patch because I had a question: > I left a few cases out, where > the %p value was not a simple pointer > but a arithmetic operation, > I don't know the rules for C, > is an addition of a pointer and a integer always of type pointer? But nobody answered :( Thus I suppose that, indeed, for all C compilers there will never be any typecast problems here... Anyone is welcome to raise up here to say the contrary... Is this OK? Pierre Muller GDB pascal language maintainer and ARI-fixer 2009-04-19 Pierre Muller ARI fix: remove "%p". * ia64-tdep.c (ia64_frame_this_id): Use host_address_to_string function. (ia64_sigtramp_frame_this_id): Ditto. (ia64_libunwind_frame_this_id): Ditto. (ia64_libunwind_sigtramp_frame_this_id): Ditto. * symmisc.c (maintenance_info_psymtabs): Ditto. Index: ia64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ia64-tdep.c,v retrieving revision 1.189 diff -u -p -r1.189 ia64-tdep.c --- ia64-tdep.c 22 Feb 2009 01:02:17 -0000 1.189 +++ ia64-tdep.c 18 Apr 2009 22:41:39 -0000 @@ -1717,10 +1717,11 @@ ia64_frame_this_id (struct frame_info *t (*this_id) = frame_id_build_special (cache->base, cache->pc, cache->bsp); if (gdbarch_debug >= 1) fprintf_unfiltered (gdb_stdlog, - "regular frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %p\n", + "regular frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %s\n", paddr_nz (this_id->code_addr), paddr_nz (this_id->stack_addr), - paddr_nz (cache->bsp), this_frame); + paddr_nz (cache->bsp), + host_address_to_string (this_frame)); } static struct value * @@ -2072,10 +2073,11 @@ ia64_sigtramp_frame_this_id (struct fram cache->bsp); if (gdbarch_debug >= 1) fprintf_unfiltered (gdb_stdlog, - "sigtramp frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %p\n", + "sigtramp frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %s\n", paddr_nz (this_id->code_addr), paddr_nz (this_id->stack_addr), - paddr_nz (cache->bsp), this_frame); + paddr_nz (cache->bsp), + host_address_to_string (this_frame)); } static struct value * @@ -2733,9 +2735,10 @@ ia64_libunwind_frame_this_id (struct fra if (gdbarch_debug >= 1) fprintf_unfiltered (gdb_stdlog, - "libunwind frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %p\n", + "libunwind frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %s\n", paddr_nz (id.code_addr), paddr_nz (id.stack_addr), - paddr_nz (bsp), this_frame); + paddr_nz (bsp), + host_address_to_string (this_frame)); } static struct value * @@ -2858,9 +2861,10 @@ ia64_libunwind_sigtramp_frame_this_id (s if (gdbarch_debug >= 1) fprintf_unfiltered (gdb_stdlog, - "libunwind sigtramp frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %p\n", + "libunwind sigtramp frame id: code 0x%s, stack 0x%s, special 0x%s, this_frame %s\n", paddr_nz (id.code_addr), paddr_nz (id.stack_addr), - paddr_nz (bsp), this_frame); + paddr_nz (bsp), + host_address_to_string (this_frame)); } static struct value * Index: symmisc.c =================================================================== RCS file: /cvs/src/src/gdb/symmisc.c,v retrieving revision 1.61 diff -u -p -r1.61 symmisc.c --- symmisc.c 17 Apr 2009 15:44:28 -0000 1.61 +++ symmisc.c 18 Apr 2009 22:41:39 -0000 @@ -1027,8 +1027,9 @@ maintenance_info_psymtabs (char *regexp, printf_filtered (" globals "); if (psymtab->n_global_syms) { - printf_filtered ("(* (struct partial_symbol **) %p @ %d)\n", - (psymtab->objfile->global_psymbols.list + printf_filtered ("(* (struct partial_symbol **) %s @ %d)\n", + host_address_to_string ( + psymtab->objfile->global_psymbols.list + psymtab->globals_offset), psymtab->n_global_syms); } @@ -1037,8 +1038,9 @@ maintenance_info_psymtabs (char *regexp, printf_filtered (" statics "); if (psymtab->n_static_syms) { - printf_filtered ("(* (struct partial_symbol **) %p @ %d)\n", - (psymtab->objfile->static_psymbols.list + printf_filtered ("(* (struct partial_symbol **) %s @ %d)\n", + host_address_to_string ( + psymtab->objfile->static_psymbols.list + psymtab->statics_offset), psymtab->n_static_syms); }