From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49816 invoked by alias); 26 Oct 2015 10:38:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49781 invoked by uid 89); 26 Oct 2015 10:38:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Oct 2015 10:38:34 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-17-2vGFdH5oQsOvkdohweEckA-1; Mon, 26 Oct 2015 10:38:29 +0000 Received: from SHAWIN202 ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 26 Oct 2015 10:38:27 +0000 From: "Thomas Preud'homme" To: "'Pedro Alves'" , "Andrew Burgess" , References: <8629fd6198d107d87d4db9b3eec45774bfaae2b6.1441996064.git.andrew.burgess@embecosm.com> <560BE7EE.2090401@redhat.com> In-Reply-To: <560BE7EE.2090401@redhat.com> Subject: RE: [PATCH 5/9] gdb: Fix bug with dbx style func command. Date: Mon, 26 Oct 2015 13:40:00 -0000 Message-ID: <003301d10fda$6e7f2ad0$4b7d8070$@arm.com> MIME-Version: 1.0 X-MC-Unique: 2vGFdH5oQsOvkdohweEckA-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00553.txt.bz2 > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Wednesday, September 30, 2015 9:47 PM >=20 > On 09/11/2015 07:49 PM, Andrew Burgess wrote: > > The func command, available when starting gdb in dbx mode, is > supposed > > to take a function name and locate the frame for that function in the > > stack. This has been broken for a while due to an invalid check of the > > arguments within the worker function. Fixed in this commit. >=20 > I wonder whether anyone uses / cares about the dbx mode... >=20 > > > > gdb/ChangeLog: > > > > * stack.c (func_command): Return early when there is no ARG > > string. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.base/dbx.exp (test_func): Remove xfails, update > expected > > results. >=20 > OK. Actually dbx style func still fails on ARM so this changes shows up as a re= gression (XFAIL- > FAIL). See [1] for a bit more details. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D19127 Best regards, Thomas