From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20875 invoked by alias); 9 Apr 2011 09:42:39 -0000 Received: (qmail 20860 invoked by uid 22791); 9 Apr 2011 09:42:37 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Apr 2011 09:42:31 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p399gSOD096457 ; Sat, 9 Apr 2011 11:42:29 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [130.79.204.11]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p399gR2P046790 ; Sat, 9 Apr 2011 11:42:28 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p399gQSD027548 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sat, 9 Apr 2011 11:42:27 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: "'Maxim Grigoriev'" Subject: [RFA] xtensa-tdep.c ARI fixes Date: Sat, 09 Apr 2011 09:42:00 -0000 Message-ID: <003301cbf69a$71f5ed10$55e1c730$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00132.txt.bz2 This patch removes three ARI warnings from xtensa-tdep.c source code. The only non-trivial change is in xtensa_register_type: this is mainly because I do not understand the old code: it was using both xmalloc and strdup, which should create a memory leak, no? But maybe I miss something? Pierre Muller as ARI maintainer. 2011-04-09 Pierre Muller ARI cleanup. * xtensa-tdep.c (xtensa_register_type): Use xstrprintf instead of sprintf. Simplify code. (xtensa_register_reggroup_p): Extract assignment out of IF clause. (call0_frame_cache): Remove && operator from end of line. Index: xtensa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v retrieving revision 1.57 diff -u -p -r1.57 xtensa-tdep.c --- xtensa-tdep.c 18 Mar 2011 18:52:32 -0000 1.57 +++ xtensa-tdep.c 9 Apr 2011 09:22:52 -0000 @@ -318,15 +318,14 @@ xtensa_register_type (struct gdbarch *gd if (tp == NULL) { - char *name = xmalloc (16); + char *name = xstrprintf ("int%d", size * 8); tp = xmalloc (sizeof (struct ctype_cache)); tp->next = tdep->type_entries; tdep->type_entries = tp; tp->size = size; - sprintf (name, "int%d", size * 8); tp->virtual_type - = arch_integer_type (gdbarch, size * 8, 1, xstrdup (name)); + = arch_integer_type (gdbarch, size * 8, 1, name); } reg->ctype = tp->virtual_type; @@ -843,7 +842,8 @@ xtensa_register_reggroup_p (struct gdbar if (group == restore_reggroup) return (regnum < gdbarch_num_regs (gdbarch) && (reg->flags & SAVE_REST_FLAGS) == SAVE_REST_VALID); - if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0) + cp_number = xtensa_coprocessor_register_group (group); + if (cp_number >= 0) return rg & (xtRegisterGroupCP0 << cp_number); else return 1; @@ -2715,9 +2715,9 @@ call0_frame_cache (struct frame_info *th too bad. */ int i; - for (i = 0; - (i < C0_NREGS) && - (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA); + for (i = 0; + (i < C0_NREGS) + && (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA); ++i); if (i >= C0_NREGS && cache->c0.c0_rt[C0_RA].fr_reg == C0_RA) i = C0_RA;