From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97043-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4171 invoked by alias); 14 Dec 2012 23:29:13 -0000
Received: (qmail 4161 invoked by uid 22791); 14 Dec 2012 23:29:12 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 23:28:37 +0000
Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBENSKhE010177           ; Sat, 15 Dec 2012 00:28:20 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms11.u-strasbg.fr [130.79.204.111])           by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBENSJLk030203           ; Sat, 15 Dec 2012 00:28:20 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBENSIeU016587 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Sat, 15 Dec 2012 00:28:18 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Tom Tromey'" <tromey@redhat.com>
Cc: "'Pedro Alves'" <palves@redhat.com>, <gdb-patches@sourceware.org>
References: <50c9b7e6.25f2440a.3810.3771SMTPIN_ADDED_BROKEN@mx.google.com>	<50CA3784.2030706@redhat.com>	<000301cdd9d0$0db345d0$2919d170$@muller@ics-cnrs.unistra.fr>	<50CAF521.3040307@redhat.com>	<43198.6185875305$1355480794@news.gmane.org> <87hano3em7.fsf@fleche.redhat.com>
In-Reply-To: <87hano3em7.fsf@fleche.redhat.com>
Subject: RE: [RFA] Fix other memory leak in solib_target_current_sos
Date: Fri, 14 Dec 2012 23:29:00 -0000
Message-ID: <003201cdda52$b4883050$1d9890f0$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00516.txt.bz2

> -----Message d'origine-----
> De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoy=E9=A0: vendredi 14 d=E9cembre 2012 15:14
> =C0=A0: Pierre Muller
> Cc=A0: 'Pedro Alves'; gdb-patches@sourceware.org
> Objet=A0: Re: [RFA] Fix other memory leak in solib_target_current_sos
>=20
> >>>>> "Pierre" =3D=3D Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
>=20
> Pierre>    library_list =3D solib_target_parse_libraries (library_documen=
t);
> Pierre>    if (library_list =3D=3D NULL)
> Pierre> -    return NULL;
> Pierre> +    {
> Pierre> +      xfree (library_document);
> Pierre> +      return NULL;
> Pierre> +    }
>=20
> It seems to me that you could unconditionally free it here, before the if.

  That's what the committed version does
thanks to Pedro's suggestion....

Pierre