From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18010 invoked by alias); 8 May 2009 12:11:19 -0000 Received: (qmail 18002 invoked by uid 22791); 8 May 2009 12:11:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 May 2009 12:11:12 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n48CB0dW016854 ; Fri, 8 May 2009 14:11:00 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n48CB0eI028512 ; Fri, 8 May 2009 14:11:00 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n48CAxdd015693 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 8 May 2009 14:10:59 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Hui Zhu'" Cc: , "'Michael Snyder'" , "'Pedro Alves'" References: <001201c9cf62$8e2761a0$aa7624e0$@u-strasbg.fr> <4A036401.6060906@vmware.com> <200905080006.19166.pedro@codesourcery.com> In-Reply-To: Subject: RE: Process record and replay checked in to main trunk Date: Fri, 08 May 2009 12:11:00 -0000 Message-ID: <003201c9cfd6$0d96d6f0$28c484d0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00175.txt.bz2 I tested this both in 32bit and 64bit CORE_ADDR length. I can confirm that cygwin compilation is fixed in both cases with that patch and hope it will be approved rapidly. Thanks, Hui. Pierre Muller Pascal language support maintainer for GDB > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Hui Zhu > Envoy=E9=A0: Friday, May 08, 2009 7:12 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org; Michael Snyder; Pedro Alves > Objet=A0: Re: Process record and replay checked in to main trunk >=20 > Hi Pierre, >=20 > I make a patch to fix this bug, but I don't have cygwin. >=20 > Could you please help me test this patch in cygwin? >=20 > Thanks, > Hui >=20 > On Fri, May 8, 2009 at 07:06, Pedro Alves > wrote: > > On Thursday 07 May 2009 23:43:13, Michael Snyder wrote: > >> Guessing it isn't implemented for 64 bit. > > > > I don't think that's the problem here. =A0Cygwin is 32-bit, and has > > 32-bit ints. > > > >> ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format, > >> uint32_t arg > > > >> ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t > >> arg (arg > > > > Better use casts, or use plongest/pulongest/hex_string where > appropriate? > > > >> Perhaps we should have a --disable-process-record config option? > >> If only for a back-up plan? > > > > I think that would be more work than fixing this properly. =A0:-) > > > >> ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared > >> (first use in this function) > > > > There are a bunch of RECORD_* macros defined on top of linux-record.c > > to replace contants like these. =A0E.g., RECORD_Q_GETFMT. =A0Looks like > > this case was just missed. > > > > -- > > Pedro Alves > >