From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56134 invoked by alias); 3 Aug 2018 19:24:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55935 invoked by uid 89); 3 Aug 2018 19:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Investigation X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Aug 2018 19:24:40 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w73JOKOs016442 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 3 Aug 2018 15:24:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 92F8D1EF36; Fri, 3 Aug 2018 15:24:20 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 153501E077; Fri, 3 Aug 2018 15:24:19 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Aug 2018 19:24:00 -0000 From: Simon Marchi To: Richard Bunt Cc: gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists In-Reply-To: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> References: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> Message-ID: <002f6b4fc45a24efb3ce3582dcecdad0@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00072.txt.bz2 On 2018-08-03 05:32, Richard Bunt wrote: > Logical short circuiting with argument lists > > When evaluating Fortran expressions such as the following: > > print truth_table(1, 1) .OR. truth_table(2, 1) > > where truth_table(1, 1) evaluates to true, the debugger would report > that it could not perform substring operations on this type. This patch > addresses this issue. > > Investigation revealed that EVAL_SKIP was not being handled correctly > for all types serviced by the OP_F77_UNDETERMINED_ARGLIST case in > evaluate_subexp_standard. While skipping an undetermined argument > list the type is resolved to be an integer (as this is what > evaluate_subexp returns when skipping) and so it was not possible to > delegate to the appropriate case (e.g. array, function call). > > The solution proposed here is to hoist the skip from the function call > case to apply to all types of argument list. > > While this patch allows a wider range of expressions to be evaluated, > it > should be noted that this patch does not allow the skipping of arrays > which use Fortran array slicing, due to the inability of the debugger > to skip OP_RANGE. > > This patch has been tested with GCC 7.3 on x86_64, aarch64 and ppc64le. Hi Richard, Thanks for the patch, hat sounds reasonnable. Just one question: > diff --git a/gdb/eval.c b/gdb/eval.c > index > 9db6e7c69dad9e674f66991e2aee7dd8d66d80c7..2350c7faaf6221a5990cf5264fe7fe93b4f4be4c > 100644 > --- a/gdb/eval.c > +++ b/gdb/eval.c > @@ -1902,6 +1902,17 @@ evaluate_subexp_standard (struct type > *expect_type, > > /* First determine the type code we are dealing with. */ > arg1 = evaluate_subexp (NULL_TYPE, exp, pos, noside); > + > + /* Allow the short-circuiting of array accesses, function calls > + and substring operations in logical expressions. */ > + if (noside == EVAL_SKIP) > + { > + /* Skip all the array subscripts. */ > + for (int i = 0; i < nargs; ++i) > + evaluate_subexp (NULL_TYPE, exp, pos, noside); > + return eval_skip_value (exp); > + } > + > type = check_typedef (value_type (arg1)); > code = TYPE_CODE (type); > > @@ -1952,8 +1963,6 @@ evaluate_subexp_standard (struct type > *expect_type, > for (; tem <= nargs; tem++) > argvec[tem] = evaluate_subexp_with_coercion (exp, pos, noside); > argvec[tem] = 0; /* signal end of arglist */ > - if (noside == EVAL_SKIP) > - return eval_skip_value (exp); Is this change needed? Your test passes even when leaving that part as-is. Thanks, Simon