Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Daniel Jacobowitz'" <drow@false.org>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFC] Trying to fix testsuite/gdb.arch/i386-sse.exp pattern 	problem
Date: Thu, 08 Nov 2007 09:50:00 -0000	[thread overview]
Message-ID: <002f01c821ec$ba48f0c0$2edad240$@u-strasbg.fr> (raw)
In-Reply-To: <20071107151120.GC20821@caradoc.them.org>



> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Wednesday, November 07, 2007 4:11 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFC] Trying to fix testsuite/gdb.arch/i386-sse.exp
> pattern problem
> 
> On Wed, Nov 07, 2007 at 03:37:45PM +0100, Pierre Muller wrote:
> > Even this simple test fails:
> >
> >     gdb_test "print {0, 0, 0, 0}" ".* =) \\{(0, ){3}(0\\}.*" "test
> array"
> >
> >  I am really wondering if this pattern repetition
> > is working at all...
> 
> Perhaps TCL relies on the system regular expression library, and
> Cygwin's does not support repetition operators?  Anyway, the TCL
> manual says they are supported, so I'm surprised by this.  Maybe Chris
> Faylor knows something about it.

   I doubt this as:
if I run this:
  grep -E "[ni]{4}" gdb.log
on Cygwin, I find all lines containing the word "running"...

  So the Cygwin system regular expression seems to support
repetition operators in a way that would also match
the list of int8 with different values.

  Do I understand correctly that this is really specific
to Cygwin? 
  
> >   I could correct the test, by putting explicitly the
> > 16 patterns, which results in an horribly lengthy pattern,
> > but I was unable to break it into pieces to have shorter source
> lines.
> >
> >   Any ideas on ways to split the pattern string sent to gdb_test
> > over multiple lines are most welcomed.
> 
> I'd use variables.
> 
> set item "-?\[0-9\]+, "
> set items "$item$item$item$item$item$item$item$item"
> append items "$item$item$item$item$item$item$item-?\[0-9\]+"

  That's indeed much better already.
But if this is really a bug in the Cygwin version of
tcl/dejagnu/runtest, then it should be solved
on that end.
  Would a patch removing the wrongly interpreted
pattern (replacing it by something like Daniel just suggested)
still be acceptable?

  
Pierre




  reply	other threads:[~2007-11-08  9:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 14:37 Pierre Muller
2007-11-07 15:11 ` Daniel Jacobowitz
2007-11-08  9:50   ` Pierre Muller [this message]
2007-11-08 10:43     ` Andreas Schwab
2007-11-08 10:55       ` Pierre Muller
2007-11-08 12:38         ` 'Daniel Jacobowitz'
2007-11-08 13:31           ` Pierre Muller
2007-11-08 13:42             ` 'Daniel Jacobowitz'
2007-11-08 14:14               ` Pierre Muller
2007-11-08 14:27                 ` 'Daniel Jacobowitz'
2007-11-08 14:51                   ` Pierre Muller
2007-11-08 15:00                     ` 'Daniel Jacobowitz'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002f01c821ec$ba48f0c0$2edad240$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox