From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24391 invoked by alias); 25 Jun 2014 01:30:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24351 invoked by uid 89); 25 Jun 2014 01:30:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jun 2014 01:29:59 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 25 Jun 2014 02:29:56 +0100 Received: from shawin252 ([10.164.2.65]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 25 Jun 2014 02:29:47 +0100 From: "Terry Guo" To: "'Pedro Alves'" Cc: References: <000b01cf8540$dafa6d80$90ef4880$@arm.com> <001701cf8555$40925540$c1b6ffc0$@arm.com> <53983C82.4040208@codesourcery.com> <001801cf85ef$f9decd40$ed9c67c0$@arm.com> <000001cf8908$49f991f0$ddecb5d0$@arm.com> <001501cf8c34$7336e840$59a4b8c0$@arm.com> <53A40465.70508@redhat.com> <001c01cf8c71$6e7295b0$4b57c110$@arm.com> <53A41949.70005@redhat.com> <002601cf8dd3$6ee6f780$4cb4e680$@arm.com> <53A8205C.50201@redhat.com> In-Reply-To: <53A8205C.50201@redhat.com> Subject: RE: [Patch]Clean up the XML files for ARM Date: Wed, 25 Jun 2014 01:30:00 -0000 Message-ID: <002e01cf9014$f2b33450$d8199cf0$@arm.com> MIME-Version: 1.0 X-MC-Unique: 114062502295600801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00871.txt.bz2 osing the prefix in the generated code is problematic for multi-arch (-- > enable-target=3Dall) builds, because this way we're open for conflict bet= ween > archs. E.g., say we have >=20 > arch1/linux.xml > arch1/linux.c > arch2/linux.xml > arch2/linux.c >=20 > Then we end up with multiple conflicting definitions of "struct target_de= sc > *tdesc_linux;" >=20 > I think we should fix this by making the directory name be a prefix in the > generated code. That is, in the ARM case, these hunks would disappear fr= om > your patch: >=20 > > -struct target_desc *tdesc_arm_with_m_vfp_d16; > > +struct target_desc *tdesc_with_m_vfp_d16; > > static void > > -initialize_tdesc_arm_with_m_vfp_d16 (void) > > +initialize_tdesc_with_m_vfp_d16 (void) > > { >=20 > Would you like to work on this? >=20 > -- > Pedro Alves >=20 You are right. I will work on this. BR, Terry