From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29712 invoked by alias); 5 May 2010 21:03:16 -0000 Received: (qmail 29568 invoked by uid 22791); 5 May 2010 21:03:14 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 21:03:04 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o45L2bDM003397 ; Wed, 5 May 2010 23:02:37 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o45L2aF3096765 ; Wed, 5 May 2010 23:02:36 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o45L2ZTB096658 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 5 May 2010 23:02:36 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Stan Shebs'" , "'Joel Brobecker'" Cc: "'Pedro Alves'" , References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> <201005051611.09790.pedro@codesourcery.com> <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> <20100505165529.GO2768@adacore.com> <4BE1A7BA.9000803@codesourcery.com> In-Reply-To: <4BE1A7BA.9000803@codesourcery.com> Subject: RE: [ARI] Remove all editCase warnings Date: Wed, 05 May 2010 21:03:00 -0000 Message-ID: <002a01caec96$4f7e3080$ee7a9180$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00126.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Stan Shebs > Envoy=E9=A0: Wednesday, May 05, 2010 7:16 PM > =C0=A0: Joel Brobecker > Cc=A0: Pierre Muller; 'Pedro Alves'; gdb-patches@sourceware.org > Objet=A0: Re: [ARI] Remove all editCase warnings >=20 > Joel Brobecker wrote: > >> static void > >> -ada_remove_Xbn_suffix (const char *encoded, int *len) > >> +ada_remove_Xbn_suffix ( /* ARI: editCase function */ > >> + const char *encoded, int *len) > >> > > > > I would rather have: > > > > ada_remove_Xbn_suffix /* ARI: editCase function */ > > (const char *encoded, int *len) > > >=20 > I frequently grep for "foo (", so this would cause the function to be > overlooked. But, fewer grep results means less work when changing the > code... :-) That is also what is done inside gdb_ari.sh, which means that it is not possible to fulfill Joel's request. Eliminating the ' (' in the pattern would probably lead to lots of false positive. I don't know what to think now... I fully agree that this is not one of the important=20 rules, but I hoped that clearing up more fields would make the ARI more efficient. Simply removing the rule is not better than=20 leaving the source code unchanged in my opinion, but I will follow the consensus if we reach one. =20=20 Pierre