From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>, "'Doug Evans'" <dje@google.com>
Cc: "'gdb-patches'" <gdb-patches@sourceware.org>
Subject: [RFA PATCH 2/3 V3] Add "class" option for pascal compiler
Date: Fri, 23 Jan 2015 05:21:00 -0000 [thread overview]
Message-ID: <002901d036a1$5c2e30f0$148a92d0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <54C0F1E5.3000207@redhat.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : jeudi 22 janvier 2015 13:50
> À : Pierre Muller; 'Doug Evans'
> Cc : 'gdb-patches'
> Objet : Re: [RFA PATCH 2/3 V2] Add "class" option for pascal compiler
>
> On 01/14/2015 03:04 PM, Pierre Muller wrote:
>
> > set result [remote_exec host $gpc_compiler "-o $dest --automake
> $add_flags $source"]
> > @@ -120,6 +127,13 @@ proc fpc_compile {source dest type options} {
> > append add_flags " -g"
> > }
> > }
> > + if { $i == "class" } {
> > + if [board_info $dest exists pascal_class_flags] {
> > + append add_flags " [board_info $dest pscal_class_flags]"
>
> It'd be good to try setting this in a board file to make sure it
> works. I've spotted a typo here (same in the gpc branch):
> "pscal_class_flags".
I corrected the error below,
but I never worked with boardinfo files,
so I am not really sure how this works.
> Thanks,
> Pedro Alves
Corrected patch below,
Pierre
gdb/ChangeLog entry:
2015-01-23 Pierre Muller <muller@sourceware.org>
* lib/pascal.exp (gpc_compile): Add new option "class".
(fpc_compile): Likewise.
---
gdb/testsuite/lib/pascal.exp | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/gdb/testsuite/lib/pascal.exp b/gdb/testsuite/lib/pascal.exp
index 994e3da..0a2aa75 100644
--- a/gdb/testsuite/lib/pascal.exp
+++ b/gdb/testsuite/lib/pascal.exp
@@ -91,6 +91,13 @@ proc gpc_compile {source dest type options} {
append add_flags " -g"
}
}
+ if { $i == "class" } {
+ if [board_info $dest exists pascal_class_flags] {
+ append add_flags " [board_info $dest pascal_class_flags]"
+ } else {
+ append add_flags " --extended-syntax"
+ }
+ }
}
set result [remote_exec host $gpc_compiler "-o $dest --automake $add_flags $source"]
@@ -120,6 +127,13 @@ proc fpc_compile {source dest type options} {
append add_flags " -g"
}
}
+ if { $i == "class" } {
+ if [board_info $dest exists pascal_class_flags] {
+ append add_flags " [board_info $dest pascal_class_flags]"
+ } else {
+ append add_flags " -Mobjfpc"
+ }
+ }
}
next prev parent reply other threads:[~2015-01-23 0:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 10:48 ` [RFA] Fix pascal behavior for class fields Pedro Alves
2015-01-08 13:01 ` Pierre Muller
[not found] ` <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 13:41 ` Pedro Alves
2015-01-08 14:15 ` gdb-patches RFA: " Pierre Muller
[not found] ` <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-09 10:52 ` Pedro Alves
2015-01-09 10:55 ` Pedro Alves
2015-01-09 16:16 ` [RFA PATCH 1/3] Remember the case pattern that allowed finding a field of this Pierre Muller
2015-01-23 7:30 ` [RFA PATCH 1/3 V3] " Pierre Muller
2015-02-04 23:37 ` [RFA PATCH 1/3 V4] " Pierre Muller
2015-01-09 16:16 ` [RFA 0/3] Fix pascal behavior for class fields with testcase Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Pierre Muller
2015-02-04 23:37 ` [RFA 0/3 V4] Fix pascal behavior for class fields with testcase Pierre Muller
2015-02-15 6:59 ` PING " Pierre Muller
2015-04-07 20:06 ` PING^2 " Pierre Muller
[not found] ` <54e043b2.626ec20a.0c59.ffffaeacSMTPIN_ADDED_BROKEN@mx.google.com>
2015-04-20 6:00 ` PING " Doug Evans
2015-04-21 20:33 ` Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pierre Muller
[not found] ` <54afff61.6790420a.0fa7.4f63SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 0:45 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Doug Evans
2015-01-10 0:55 ` Pierre Muller
[not found] ` <54b07891.01b3c20a.2a7b.ffff9f96SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 21:23 ` Doug Evans
2015-01-14 15:04 ` [RFA PATCH 2/3 V2] Add "class" " Pierre Muller
[not found] ` <54b6858f.a287440a.5b61.ffff9ef0SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:49 ` Pedro Alves
2015-01-23 5:21 ` Pierre Muller [this message]
2015-01-23 11:55 ` [RFA PATCH 2/3 V3] " Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 2/3 V4] " Pierre Muller
[not found] ` <54afff6b.ee8d440a.16ee.ffffb424SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:46 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pedro Alves
2015-01-23 7:16 ` [RFA PATCH 3/3 V3] " Pierre Muller
2015-01-23 12:29 ` Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 3/3 V4] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002901d036a1$5c2e30f0$148a92d0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox