Re: [RFC-v4] Add windows OS Thread Information Block

Christopher Faylor
2010-03-16T00:10:43Z

On Mon, Mar 15, 2010 at 10:40:38PM +0100, Pierre Muller wrote:
> This is a new version of my patch to add support for
>displaying thread-information-block for Windows OS
>inferior programs.
>
> I tried to follow several advices I got earlier and made several
>changes.
> The most important one concerns the remote/gdbserver communication:
>instead of using TARGET_OBJECT_DATA, I defined a new target_ops method
>called to_get_tib_address and defined a new query packet
>PACKET_qGetTIBAddr adapted from the existing PACKET_qGetTLSAddr.
>
> I also tried to write a first draft of the documentation
>patch and hope for some input from Eli on this matter...
>
> There are only minor changes in the windows-nat and windows-tdep files,
>the main one being the adaptation to the new to_get_tib_addr
>field of the target_ops struct.
>
> I hope this new version will be closer to the expectation
>of most of you and look forward to hearing your comments.
>
>
>Pierre
>
>PS: After checking, I indeed change the order of
>active_rpc_handle and thead_local_storage fields in

You call this "thead" rather than "thread" in a couple of places.

Other than that it looks ok, assuming that others concerns have
been addressed.

Thanks.

cgf