Re: [RFC-v2] Add windows Thread Information Block

Christopher Faylor
2009-07-01T21:13:56Z

On Wed, Jul 01, 2009 at 08:19:16PM +0100, Pedro Alves wrote:
>On Wednesday 01 July 2009 20:10:04, Christopher Faylor wrote:
>>It's unreasonable to assume that a cross gdb configuration which
>>understands Windows would be able to use the w32api header files?
>
>It could be e.g, a ppc64-linux x x86-mingw GDB. A ppc64-linux-gcc
>wouldn't be able to compile the headers, and if it did by miracle, the
>ABI (structure layout, endianess, etc.) would be wrong all over.

Ok, point taken. Then at the very least the file should make it clear
where the values come from, by including a pointer to, e.g., MSDN or,
maybe some other source which doesn't change as much. And, add some
more descriptive comments (although I do like the fs:OFFSET comments).

As someone who has had to look these fields up many times in the past
I don't think it pays to skimp on documentation.

cgf