From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59492 invoked by alias); 30 Sep 2016 21:09:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59481 invoked by uid 89); 30 Sep 2016 21:09:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.1 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 spammy=U*owner, gdbpatchesownersourcewareorg, gdb-patches-owner@sourceware.org, U*gdb-patches-owner X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Sep 2016 21:09:25 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id E24CE143446; Fri, 30 Sep 2016 23:09:22 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id CDF5A14514B; Fri, 30 Sep 2016 23:09:22 +0200 (CEST) Received: from local-mr.u-strasbg.fr (lmr4.u-strasbg.fr [172.30.21.4]) by mr2.u-strasbg.fr (Postfix) with ESMTP id AA2D5143446; Fri, 30 Sep 2016 23:09:20 +0200 (CEST) Received: from local-mr.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 7D9059B; Fri, 30 Sep 2016 23:09:20 +0200 (CEST) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (Authenticated sender: mullerp) by lmr4.u-strasbg.fr (Postfix) with ESMTPSA id 1FC0692; Fri, 30 Sep 2016 23:09:17 +0200 (CEST) From: "Pierre Muller" To: "'Anton Kolesov'" Cc: References: <1475258387-26605-1-git-send-email-Anton.Kolesov@synopsys.com> In-Reply-To: <1475258387-26605-1-git-send-email-Anton.Kolesov@synopsys.com> Subject: RE: [PATCH] arc: Remove annoying debug message Date: Fri, 30 Sep 2016 21:16:00 -0000 Message-ID: <002801d21b5e$e81742c0$b845c840$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-09/txt/msg00440.txt.bz2 Hi, I was wondering if it would not be better to restrict such debug for higher debugging levels. According to _initialize_arc_tdep, arc_debug is an integer value, and can thus be set to values above 1, to get more verbose output. Thus another modification could be: if (arc_debug > 1) debug_printf ("arc: frame_prev_register (regnum =3D %d)\n", regnum); Similar code is already used for record_debug or gdbarch_debug variables.=20 Pierre Muller > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Anton Kolesov > Envoy=E9=A0: vendredi 30 septembre 2016 20:00 > =C0=A0: gdb-patches@sourceware.org > Cc=A0: Anton Kolesov; Francois Bedard > Objet=A0: [PATCH] arc: Remove annoying debug message >=20 > This logging message is called too often - once for each register when > it's > value has to be evaluated. This floods the screen for commands like > "info > register all", but doesn't give really any help at debugging GDB > issues. > Between increasing the debug level of this message and removing it > altogether I > think that removing it is preferable. >=20 > gdb/ChangeLog: >=20 > arc-tdep.c (arc_frame_prev_register): Remove annoying log > message. > --- > gdb/arc-tdep.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c > index 7bb93ad..60a4e04 100644 > --- a/gdb/arc-tdep.c > +++ b/gdb/arc-tdep.c > @@ -876,9 +876,6 @@ static struct value * > arc_frame_prev_register (struct frame_info *this_frame, > void **this_cache, int regnum) > { > - if (arc_debug) > - debug_printf ("arc: frame_prev_register (regnum =3D %d)\n", regnum); > - > if (*this_cache =3D=3D NULL) > *this_cache =3D arc_make_frame_cache (this_frame); > struct arc_frame_cache *cache =3D (struct arc_frame_cache *) > (*this_cache); > -- > 2.8.1