From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4366 invoked by alias); 17 Dec 2013 08:43:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4356 invoked by uid 89); 17 Dec 2013 08:43:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.213) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2013 08:43:54 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 9D4A2C01C2; Tue, 17 Dec 2013 09:43:51 +0100 (CET) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 8CCFCC0130; Tue, 17 Dec 2013 09:43:51 +0100 (CET) Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248]) by mr3.u-strasbg.fr (Postfix) with ESMTP id 49042C02B4; Tue, 17 Dec 2013 09:43:48 +0100 (CET) Received: from ms15.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id rBH8hlU7029068 ; Tue, 17 Dec 2013 09:43:47 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms15.u-strasbg.fr (Postfix) with ESMTPSA id E7D121FD8A; Tue, 17 Dec 2013 09:43:44 +0100 (CET) From: "Pierre Muller" To: "'Yao Qi'" , "'Pedro Alves'" Cc: References: <002f01cef853$f44500e0$dccf02a0$@muller@ics-cnrs.unistra.fr> <52AE633E.9020604@codesourcery.com> <52AF40E4.1020709@redhat.com> <52AF9D9C.4000908@codesourcery.com> In-Reply-To: <52AF9D9C.4000908@codesourcery.com> Subject: RE: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing Date: Tue, 17 Dec 2013 08:43:00 -0000 Message-ID: <002801cefb04$19a863b0$4cf92b10$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-12/txt/msg00613.txt.bz2 > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Yao Qi > Envoy=C3=A9 : mardi 17 d=C3=A9cembre 2013 01:41 > =C3=80 : Pedro Alves > Cc : Pierre Muller; gdb-patches@sourceware.org > Objet : Re: [RFA] Fix cygwin compilation failure due to nameless > LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing >=20 > On 12/17/2013 02:05 AM, Pedro Alves wrote: > > At this level we're thinking in terms of Win32 debug API, and > > it's irrelevant what Cygwin thinks is the Posix path of > > ntdll.dll. If this is indeed ntdll.dll, then the following > > windows_make_so call will then do that conversion before > > recording the dll name. >=20 > My point is we use cygwin_conv_path to convert the path to type "char > *" > and then compare whether it is ntdll.dll. As Pedro explained, I don't think this is useful here, because we only check the filename part of the DLL, this is not changed by the cygwin_conv_path which only converts Windows OS paths into cygwin paths. Moreover, windows_make_so expect a windows OS path, which is copied into so_original_name while so_name gets the return value of cygwin_conv_path. Thus I would expect that your idea to call cygwin_conv_path=20 inside windows_ensure_ntddl_loaded would lead to a failure at the start of the windows_make_so which calls the Win32 API function FindFirstFile. I hope this clarifies the point. Pierre Muller